Update v6 branch: Add stripWitness to Transaction Issue 2169 #2170 #2171
Conversation
src/transaction.js
Outdated
| prevOutScripts.length !== this.ins.length | ||
| ) { | ||
| throw new Error('Must supply prevout script and value for all inputs'); | ||
| stripWitnesses() { |
There was a problem hiding this comment.
@junderw I wasn't sure what to do with these changes. Should I just not commit the build changes?
There was a problem hiding this comment.
It might be a version diff.
Wipe node_modules and install deps using npm ci and it should be correct. (That's what CI does)
I think master has a newer version of the formatter and maybe your local node_modules still had that newer version (whereas CI will pull the older version).
There was a problem hiding this comment.
Then just run npm run format && npm run build and it should give you only the diff in your js similar to the ts, and a new function for the d.ts types file.
There was a problem hiding this comment.
Ahh, yeah, that makes complete sense. Sorry, I'm a bit rusty.
|
Also, remove the audit CI job and the better-npm-audit dev dependency. (We got rid of it) |
Done. I'd be happy to make a separate PR for this if you want, but it seems pretty safe. |
This PR aligns the v6 branch with the recent changes to master.
This PR is intended to solve issue 2169