-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stripWitnesses to Transaction #2169
Comments
I made a Please make the PR towards v6 for now and I'll release it as a minor version bump. If you want to make a second PR against master as well that would be appreciated. |
@junderw Yeah, I would. I'll start reading up and try to get something in soon. |
@junderw no rush at all, but I made a pull request whenever you have time. |
I'll leave this issue open until we backport to v6. (Pull the v6 branch, do essentially the same commit on top, then open a PR against the v6 branch instead of master) |
Oops, thanks for reminding me. Some tests are failing on V6 at the moment, so it was easier for me to work against Master while I'm still trying to learn the codebase. I meant to swing back to v6, but it slipped my mind. Here is the PR, but I have one question. |
@junderw are we good to close this one out now? |
Replaces #1951
Iterate through ins and replace witness with EMPTY_WITNESS.
@JacksonDMiller wanna take a crack at it?
The text was updated successfully, but these errors were encountered: