Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stripWitnesses to Transaction #2169

Closed
junderw opened this issue Sep 25, 2024 · 6 comments
Closed

Add stripWitnesses to Transaction #2169

junderw opened this issue Sep 25, 2024 · 6 comments

Comments

@junderw
Copy link
Member

junderw commented Sep 25, 2024

Replaces #1951

Iterate through ins and replace witness with EMPTY_WITNESS.

@JacksonDMiller wanna take a crack at it?

@junderw
Copy link
Member Author

junderw commented Sep 25, 2024

I made a v6 branch for backporting.

Please make the PR towards v6 for now and I'll release it as a minor version bump.

If you want to make a second PR against master as well that would be appreciated.

@JacksonDMiller
Copy link
Contributor

@junderw Yeah, I would. I'll start reading up and try to get something in soon.

@JacksonDMiller
Copy link
Contributor

@junderw no rush at all, but I made a pull request whenever you have time.

@junderw
Copy link
Member Author

junderw commented Sep 30, 2024

I'll leave this issue open until we backport to v6.

(Pull the v6 branch, do essentially the same commit on top, then open a PR against the v6 branch instead of master)

@JacksonDMiller
Copy link
Contributor

I'll leave this issue open until we backport to v6.

(Pull the v6 branch, do essentially the same commit on top, then open a PR against the v6 branch instead of master)

Oops, thanks for reminding me. Some tests are failing on V6 at the moment, so it was easier for me to work against Master while I'm still trying to learn the codebase. I meant to swing back to v6, but it slipped my mind.

Here is the PR, but I have one question.

@JacksonDMiller
Copy link
Contributor

@junderw are we good to close this one out now?

@junderw junderw closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants