Huge list command performance improvement to make loading results instant #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l tabs titles/urls in double entries arrays (matching windows/tabs indexes) instead of requesting the values in a double for loop.
|
This is amazing BTW.. Initially my tabs were taking 20~30 seconds to retrieve. After applying these code changes locally it loaded instantly |
|
Just realized this initial work was done almost a year ago. Is @bit2pixel around? Any chance for a merge? |
|
In case anyone's impatient, I just pushed a release 1.0.4 to my fork that incorporates this and a couple of other minor fixes. |
|
@AnthoPakPak thank you so much for contributing, this is fantastic! I'm merging this in and will create a new Alfred workflow on the weekend. |
Hey @luckman212, thanks for the ping! I took a break from github, back now, just merged the changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've stated in the issue #6 (Any way to improve list efficiency?), since I've got hundreds of tabs opened, I often has to wait up to 10 seconds for the
listcommand to return the results.After lot of research I've founded out a way to improve the command efficiency.
This is done by initially storing all tabs titles/urls in double entries arrays (matching windows/tabs indexes) instead of requesting the values in a double for loop.
The difference is blazing! Results are now returned almost instantly even when you have hundreds of tabs. I hope code will be merged so that others will also profit from these changes 👌