-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any way to improve list efficiency? #6
Comments
I've had the same issue. Code looks nice, but performance for a heavy tab user is too slow - around 7-10 seconds for me to wait for results, so I am much faster to open Chrome myself and use an extension to search for my tab. As my main intent was opening a specific tab, I've automated this extension via Alfred and osascript. |
@mschmidtkorth Oh yeah, I didn't thought of doing it! I would be really interested to know how you did this! If you don't mind, could you please tell me the extension used, and maybe share the script? Would be awesome! |
@AnthoPakPak Sure! The Chrome extension is Tab Ahead, which has a keycombo of |
@mschmidtkorth Thanks a lot! I'll take a look at it. Indeed, not having the list in Alfred could be a major drawback… I think one major improvement to chrome-control would have been to cache tabs, I'll see if if I can do something like this someday. Like storing opened tabs in a file every minute, so that Alfred will show them instantly (while still refreshing the list to make sure opened tabs less than a minute ago are still showed). |
@AnthoPakPak Yes, it is quite cumbersome. One option would be:
|
@mschmidtkorth Wow this tool seems awesome! I've managed to get it working, thanks for the instructions! The only issue is that |
@mschmidtkorth BOOM! After searching hours into |
@AnthoPakPak Nice!! It is MUCH faster now, great! However, for me this has removed the ability to search for URLs instead of tab names (example: Google Mail's tab title changes if someone sends you a chat message, then I can no longer switch). Was this intended? |
@mschmidtkorth Hi! Are you sure? I've noticed this also but when trying the initial version it was the same results (some are missing…). But I also wanted to improve this, I'll take a look! |
@AnthoPakPak Actually I'm not sure whether this was part of the original implementation. Might just have been wishful thinking :-) Edit: See attached for a version with fuzzy matching on title and subtitle. |
@mschmidtkorth Funnily enough I'm only seeing your edit now 😅 I had meanwhile made the changes on my side so that the search works in title and subtitle, but I'm glad to found your fuzzy version! I've just integrated the required changes in my workflow and it works perfectly! 👌 |
@AnthoPakPak I played around with this and the matching wasn't working great for URLs that start with I forked and uploaded a version that extracts the base URL and breaks it up into words so e.g. searching |
Comments@mschmidtkorth implementation is great. Indexing is super fast, and my tab searches are reliable. Oddly, I think dashes were not working so well in the original version? One of my tab titles had a dash in it, and as soon as I typed the dash, I lost all search results. But this one fixes it. However, I think the fuzzy search is a bit finicky. I'm not sure why this is my top search result over the second result. RequestThis issue alone now has two separate chrome-control solutions floating around. Anyway these can be merged into the original chrome-control? It'll be less confusing and people who don't read GitHub issues will also benefit from these improvements. |
Hi!
First, thanks a lot for this awesome Alfred workflow, I really enjoy using it! 👌
The only thing I struggle with is the fact that listing the tabs is too slow. I have hundreds of opened tabs and it takes several seconds before showing the tabs list (sometimes up to 10seconds). So unfortunately, I lose a lot of time waiting the loading…
I've looked at the code, but from what I see the logic is nice, and I don't see a straightforward way to improve the efficiency. I guess the slow part is the looping through windows/tabs, but I can't find a better way to do it.
Do you have any advice, idea, which could lead to improved efficiency?
The text was updated successfully, but these errors were encountered: