User XML configuration persistence #380

rlebre · 2019-03-26T11:12:18Z

Improvements in the User servlets:

Delete user is now in accordance with REST, i.e. receiving parameter as PathParam
Users added by webservice are now persisted in the users.xml file

Small improvement: .gitnore now contains MacOS files and folders

Login and Logout Servlets do not throw useless exceptions PUT REST service replaced with proper POST method to add users add users are now persisted in the xml file

…ving username as PathParam)

Enet4

This is one of those classes where a refactoring like the one in #284 would have been beneficial. In the mean time, I am not opposed to adding this fix (I do consider this to be a bug).

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersStruct.java

dicoogle/src/main/java/pt/ua/dicoogle/server/web/servlets/accounts/UserServlet.java

Enet4 · 2019-03-26T11:33:59Z

dicoogle/src/main/java/pt/ua/dicoogle/server/web/servlets/accounts/UserServlet.java

    }

    @Override
-    protected void doPut(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
+    protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException {


This is a public web API change. Is it really important that we change the method? Couldn't PUT be adapted to also enable updating existing users?

Since the doPost assumes the creation of a new element; since doPut assumes the edition/replacement of a new element; since, according to literature, the previous format was not in compliance. I believe this is the best way to do it.
https://spring.io/understanding/REST

Again, we can think of this the other way around: if this implementation PUT does not support updating a user's properties, that can be improved. As much as we'd like to have a "pure" RESTful interface, we do not mandate such a design in Dicoogle. This part of the API was designed like this, and changing it is something we should not be accustomed to, since it has to be changed in client-sided code. As far as this one's concerned, the "resource" is a service.

dicoogle/src/main/java/pt/ua/dicoogle/server/web/servlets/accounts/UserServlet.java

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersXML.java

updated return statement getDefaults() implemented hashing in default user to be in line with the other methods bugfix when users.xml wasn't created, the dicoogle dicoogle didn't work

removed unused import

replaced regex by split

Enet4

I found a few more issues.

dicoogle/src/main/java/pt/ua/dicoogle/server/web/servlets/accounts/UserServlet.java

improved filewriting on UserFileHandle

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UserFileHandle.java

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersXML.java

…ed in the UsersStruct, voiding the deletion of admin users

Enet4

Other than these issues, we still need to sort this one out. This is not a severe change, considering that we're not using it in the web application yet, but it's a change we ought to keep recorded.

@bastiao Do you agree with changing PUT /user to POST /user for creating new users?

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersXML.java

bastiao · 2019-04-16T21:50:19Z

Agreed! We can modify it for POST.
It sounds good to have this PR.

rlebre added 4 commits March 24, 2019 20:22

UsersStruct handles now the extension users (replaces UserXML)

feb44c3

Login and Logout Servlets do not throw useless exceptions PUT REST service replaced with proper POST method to add users add users are now persisted in the xml file

updated gitignore for MacOS temp files

091ca9b

Delete user REST method is now in accordance with the standard (recei…

98b653f

…ving username as PathParam)

users.xml updated after deleting a user

8ae3645

Enet4 changed the title ~~Imp/user xml persitence~~ User XML configuration persistence Mar 26, 2019

Enet4 added bug enhancement dicoogle-core labels Mar 26, 2019

Enet4 requested changes Mar 26, 2019

View reviewed changes

rlebre added 3 commits March 26, 2019 13:23

removed tag <p> from empty lines in comments

ae770f6

updated return statement getDefaults() implemented hashing in default user to be in line with the other methods bugfix when users.xml wasn't created, the dicoogle dicoogle didn't work

removed <p> tag

e1e4d63

removed unused import

updated UserServlet to deal with user not provided

36f5d40

replaced regex by split

Enet4 requested changes Mar 26, 2019

View reviewed changes

dicoogle/src/main/java/pt/ua/dicoogle/server/web/servlets/accounts/UserServlet.java Outdated Show resolved Hide resolved

dicoogle/src/main/java/pt/ua/dicoogle/server/web/servlets/accounts/UserServlet.java Show resolved Hide resolved

rlebre added 3 commits March 26, 2019 16:50

updated tests to support UsersStruct changes

d3b1022

<p> tag replacement

36307a5

updated logging

2a8c211

improved filewriting on UserFileHandle

rlebre requested a review from Enet4 March 27, 2019 11:19

Enet4 requested changes Mar 27, 2019

View reviewed changes

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UserFileHandle.java Outdated Show resolved Hide resolved

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersXML.java Outdated Show resolved Hide resolved

rlebre added 3 commits March 27, 2019 13:46

final modifier in logger declaration

6c6ccab

added try-with-resources fix

42288a3

bugfix: when getting defaults, the number of admins was not increment…

c618cf6

…ed in the UsersStruct, voiding the deletion of admin users

rlebre requested a review from Enet4 April 2, 2019 17:15

Enet4 requested changes Apr 3, 2019

View reviewed changes

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersXML.java Outdated Show resolved Hide resolved

dicoogle/src/main/java/pt/ua/dicoogle/server/users/UsersXML.java Outdated Show resolved Hide resolved

rlebre added 2 commits April 4, 2019 15:46

Updated logger error messages

dfbe0df

updated for cycle to stream()

37dec60

Enet4 approved these changes Apr 17, 2019

View reviewed changes

Enet4 merged commit dcdec85 into bioinformatics-ua:dev Apr 18, 2019

rlebre mentioned this pull request Oct 17, 2019

user creation and removal bioinformatics-ua/dicoogle-learning-pack#13

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User XML configuration persistence #380

User XML configuration persistence #380

rlebre commented Mar 26, 2019

Enet4 left a comment

Enet4 Mar 26, 2019

rlebre Mar 26, 2019

Enet4 Mar 26, 2019 •

edited

Loading

Enet4 left a comment

Enet4 left a comment

bastiao commented Apr 16, 2019 •

edited

Loading

User XML configuration persistence #380

User XML configuration persistence #380

Conversation

rlebre commented Mar 26, 2019

Enet4 left a comment

Choose a reason for hiding this comment

Enet4 Mar 26, 2019

Choose a reason for hiding this comment

rlebre Mar 26, 2019

Choose a reason for hiding this comment

Enet4 Mar 26, 2019 • edited Loading

Choose a reason for hiding this comment

Enet4 left a comment

Choose a reason for hiding this comment

Enet4 left a comment

Choose a reason for hiding this comment

bastiao commented Apr 16, 2019 • edited Loading

Enet4 Mar 26, 2019 •

edited

Loading

bastiao commented Apr 16, 2019 •

edited

Loading