Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user creation and removal #13

Merged
merged 11 commits into from
Apr 27, 2021

Conversation

rlebre
Copy link
Member

@rlebre rlebre commented Oct 16, 2019

Added section in Configuration page about creation and removal of users. However, this pull request only takes into account the dev branch in bioinformatics-ua/dicoogle as it considers the refactored user web services.

Solves #11

Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pull request only takes into account the dev branch in bioinformatics-ua/dicoogle as it considers the refactored user web services.

Can you double-check whether there were any changes in this services? As far as I can recall, this should still work in v2.

_docs/configuring.md Show resolved Hide resolved
_docs/configuring.md Show resolved Hide resolved
@rlebre
Copy link
Member Author

rlebre commented Oct 17, 2019

@Enet4 in fact, I think v2.5.0 only supports the HTTP method PUT to create a user. Changes have been made to change the API from PUT to POST and change also the DELETE method. The pull request referring that is bioinformatics-ua/dicoogle#380

Regarding the white spaces commented above, they were added by markdown-formatter plugin for VSCode. Although there was not complain by an editor, I can revert upon your confirmation about this matter.

@Enet4
Copy link
Collaborator

Enet4 commented Oct 17, 2019

Right, now I remember that change. You can document it as PUT in the main corpus and append an "unreleased" block to document the next version.

<div class="note unreleased" >
<h5>Breaking change in Dicoogle 3</h5>
<p>Starting from Dicoogle 3.0.0, creating new users should be done with the `POST` method instead of `PUT`.</p>
</div>

added warning to use POST method starting from v3.0.0
…ot persist added users by API. Dicoogle v3.0.0 bugfixes do it
@rlebre
Copy link
Member Author

rlebre commented Oct 17, 2019

Also fixed the wrong method to delete users.
Moreover, I added the information of the persistence of the users in users.xml to the note unreleased, as the fixes are applied only in v3.0.0 by bioinformatics-ua/dicoogle#380

_docs/configuring.md Outdated Show resolved Hide resolved
_docs/configuring.md Outdated Show resolved Hide resolved
_docs/configuring.md Outdated Show resolved Hide resolved
_docs/configuring.md Outdated Show resolved Hide resolved
_docs/configuring.md Outdated Show resolved Hide resolved
@rlebre rlebre closed this Oct 30, 2019
@rlebre rlebre deleted the new/user_create_remove branch October 30, 2019 16:59
@rlebre rlebre restored the new/user_create_remove branch November 4, 2019 11:57
@rlebre rlebre reopened this Nov 4, 2019
Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bring in pending changes and work on fresh new content for the learning pack!

@Enet4 Enet4 merged commit 88d84c6 into bioinformatics-ua:master Apr 27, 2021
@Enet4 Enet4 mentioned this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants