-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user creation and removal #13
user creation and removal #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pull request only takes into account the dev branch in bioinformatics-ua/dicoogle as it considers the refactored user web services.
Can you double-check whether there were any changes in this services? As far as I can recall, this should still work in v2.
@Enet4 in fact, I think v2.5.0 only supports the HTTP method PUT to create a user. Changes have been made to change the API from PUT to POST and change also the DELETE method. The pull request referring that is bioinformatics-ua/dicoogle#380 Regarding the white spaces commented above, they were added by markdown-formatter plugin for VSCode. Although there was not complain by an editor, I can revert upon your confirmation about this matter. |
Right, now I remember that change. You can document it as <div class="note unreleased" >
<h5>Breaking change in Dicoogle 3</h5>
<p>Starting from Dicoogle 3.0.0, creating new users should be done with the `POST` method instead of `PUT`.</p>
</div> |
added warning to use POST method starting from v3.0.0
…ot persist added users by API. Dicoogle v3.0.0 bugfixes do it
Also fixed the wrong method to delete users. |
Co-Authored-By: Eduardo Pinho <[email protected]>
Co-Authored-By: Eduardo Pinho <[email protected]>
Co-Authored-By: Eduardo Pinho <[email protected]>
Co-Authored-By: Eduardo Pinho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's bring in pending changes and work on fresh new content for the learning pack!
Added section in Configuration page about creation and removal of users. However, this pull request only takes into account the dev branch in bioinformatics-ua/dicoogle as it considers the refactored user web services.
Solves #11