Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONCOCT: Stricter pinning for sci-kit-learn dependency #48626

Closed
wants to merge 11 commits into from
Closed

Update CONCOCT: Stricter pinning for sci-kit-learn dependency #48626

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e37e90d
Stricter pinning fo sci-kit-learn
jfy133 Jun 20, 2024
73b88cb
Try fixing OPENBLAS loops as per https://github.com/conda-forge/openb…
jfy133 Jun 20, 2024
fb758a8
Update recipes/concoct/meta.yaml
jfy133 Jun 20, 2024
92038d4
Pin python version range
jfy133 Jun 20, 2024
1b0f300
Revert to @prototaxites last update
jfy133 Jun 20, 2024
977aa3c
Properly roll back to Prototaxites version
jfy133 Jun 20, 2024
fb49ec7
Use variables for name/version
jfy133 Jun 20, 2024
282dd0c
Try to set python_abi to sufficiently low version
jfy133 Jun 20, 2024
f806446
Update recipes/concoct/meta.yaml
jfy133 Jun 20, 2024
e65e508
Try losening again the scikit-learn pin
jfy133 Jun 20, 2024
3fb17fa
Try removing scikit-learn depdency
jfy133 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions recipes/concoct/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ source:

build:
preserve_egg_dir: True
number: 5
number: 6
skip: True # [osx]
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}
Expand All @@ -34,7 +34,7 @@ requirements:
- pandas >=0.11.0
- biopython >=1.62b
- pytz >=2013.9
- scikit-learn >=1.1.3
- scikit-learn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the logs now it uses scikit-learn: 1.5.0-py312h1fcc3ea_1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool, I'm on baby duty today but when I get a chance I'll try and get the docker image/build the environment and try running concoct to see if the error people are getting is there or not.

- nose >=1.3.0
- gsl
- samtools
Expand All @@ -52,8 +52,6 @@ about:
license_family: BSD

extra:
additional-platforms:
- linux-aarch64
skip-lints:
- uses_setuptools # concoct uses pkg_resources
- cython_must_be_in_host # Cython needs to be in run as well currently
Expand Down