Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONCOCT: Stricter pinning for sci-kit-learn dependency #48626

Closed
wants to merge 11 commits into from

Conversation

jfy133
Copy link
Contributor

@jfy133 jfy133 commented Jun 20, 2024

Following solution here: BinPro/CONCOCT#321


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jfy133 jfy133 closed this Jun 20, 2024
@jfy133 jfy133 deleted the concoct branch June 20, 2024 13:07
@jfy133 jfy133 restored the concoct branch June 20, 2024 13:33
@jfy133 jfy133 reopened this Jun 20, 2024
recipes/concoct/meta.yaml Outdated Show resolved Hide resolved
@jfy133
Copy link
Contributor Author

jfy133 commented Jun 20, 2024

@martin-g I have a feeling it isn't going to work with the ARM build... my intuition is the scikit-learn pin is going to force the python_abi to a version unsupported with ARM (but note I know 0 about these the ARM/aarch64 build stuff)

CONCOCT is quite old now

recipes/concoct/meta.yaml Outdated Show resolved Hide resolved
recipes/concoct/meta.yaml Outdated Show resolved Hide resolved
@@ -34,7 +34,7 @@ requirements:
- pandas >=0.11.0
- biopython >=1.62b
- pytz >=2013.9
- scikit-learn >=1.1.3
- scikit-learn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the logs now it uses scikit-learn: 1.5.0-py312h1fcc3ea_1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool, I'm on baby duty today but when I get a chance I'll try and get the docker image/build the environment and try running concoct to see if the error people are getting is there or not.

@jfy133
Copy link
Contributor Author

jfy133 commented Jun 21, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 concoct-1.1.0-py312h245ed52_6.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
concoct 1.1.0--py312h245ed52_6 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/concoct:1.1.0--py312h245ed52_6.tar.gz | docker load

@jfy133
Copy link
Contributor Author

jfy133 commented Jun 21, 2024

CLosing again for #48624 as it's more advanced

@jfy133 jfy133 closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants