Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement trait generics on impl-for #76

Merged
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 50 additions & 6 deletions src/generate/impl_for.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ pub struct ImplFor<'a, P: Parent> {
type_name: StringOrIdent,
trait_name: Option<StringOrIdent>,
lifetimes: Option<Vec<String>>,
generics: Option<Vec<String>>,
consts: Vec<StreamBuilder>,
custom_generic_constraints: Option<GenericConstraints>,
impl_types: Vec<StreamBuilder>,
Expand All @@ -32,6 +33,7 @@ impl<'a, P: Parent> ImplFor<'a, P> {
trait_name,
type_name,
lifetimes: None,
generics: None,
consts: Vec::new(),
custom_generic_constraints: None,
impl_types: Vec::new(),
Expand Down Expand Up @@ -77,6 +79,31 @@ impl<'a, P: Parent> ImplFor<'a, P> {
self
}

/// Add generic parameters to the trait implementation.
///```
/// # use virtue::prelude::Generator;
/// # let mut generator = Generator::with_name("Bar");
/// generator.impl_for("Foo")
/// .with_trait_generics(["Baz"]);
/// # generator.assert_eq("impl Foo < Baz > for Bar { }");
/// # Ok::<_, virtue::Error>(())
/// ```
///
/// Generates:
/// ```ignore
/// impl Foo for <struct or enum> {
/// const BAR: u8 = 5;
/// }
/// ```
pub fn with_trait_generics<ITER>(mut self, generics: ITER) -> Self
where
ITER: IntoIterator,
ITER::Item: Into<String>,
{
self.generics = Some(generics.into_iter().map(Into::into).collect());
self
}

/// Add a outer attribute to the trait implementation
pub fn impl_outer_attr(&mut self, attr: impl AsRef<str>) -> Result {
let mut builder = StreamBuilder::new();
Expand Down Expand Up @@ -259,16 +286,17 @@ impl<P: Parent> ImplFor<'_, P> {
if let Some(generics) = self.generator.generics() {
builder.append(generics.impl_generics_with_additional_lifetimes(lifetimes));
} else {
append_lifetimes(builder, lifetimes);
append_generics(builder, lifetimes, &[]);
NightEule5 marked this conversation as resolved.
Show resolved Hide resolved
}
} else if let Some(generics) = self.generator.generics() {
builder.append(generics.impl_generics());
}
if let Some(t) = &self.trait_name {
builder.push_parsed(t.to_string()).unwrap();
if let Some(lifetimes) = &self.lifetimes {
append_lifetimes(builder, lifetimes);
}

let lifetimes = self.lifetimes.as_deref().unwrap_or_default();
let generics = self.generics.as_deref().unwrap_or_default();
append_generics(builder, lifetimes, generics);
NightEule5 marked this conversation as resolved.
Show resolved Hide resolved
builder.ident_str("for");
}
builder.push_parsed(self.type_name.to_string()).unwrap();
Expand All @@ -283,10 +311,26 @@ impl<P: Parent> ImplFor<'_, P> {
}
}

fn append_lifetimes(builder: &mut StreamBuilder, lifetimes: &[String]) {
fn append_generics(builder: &mut StreamBuilder, lifetimes: &[String], generics: &[String]) {
NightEule5 marked this conversation as resolved.
Show resolved Hide resolved
if lifetimes.is_empty() && generics.is_empty() {
return;
}

builder.punct('<');

for (idx, lt) in lifetimes.iter().enumerate() {
builder.punct(if idx == 0 { '<' } else { ',' });
if idx > 0 {
builder.punct(',');
}
builder.lifetime_str(lt);
}

for (idx, gen) in generics.iter().enumerate() {
if idx > 0 || !lifetimes.is_empty() {
builder.punct(',');
}
builder.ident_str(gen);
}

builder.punct('>');
}
Loading