-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement trait generics on impl-for #76
Implement trait generics on impl-for #76
Conversation
5a4f7c7
to
591db72
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #76 +/- ##
==========================================
+ Coverage 48.06% 48.42% +0.35%
==========================================
Files 20 20
Lines 2041 2030 -11
==========================================
+ Hits 981 983 +2
+ Misses 1060 1047 -13
☔ View full report in Codecov by Sentry. |
591db72
to
2fcd88b
Compare
2fcd88b
to
8b871e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick, looks good otherwise
3f58bc6
to
cd75149
Compare
cd75149
to
2369461
Compare
Thanks! |
Closes #70