Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement trait generics on impl-for #76

Merged

Conversation

NightEule5
Copy link
Contributor

Closes #70

@NightEule5 NightEule5 force-pushed the feature/impl-for-trait-generics branch from 5a4f7c7 to 591db72 Compare November 10, 2023 15:01
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (39db1c8) 48.06% compared to head (2369461) 48.42%.
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk      #76      +/-   ##
==========================================
+ Coverage   48.06%   48.42%   +0.35%     
==========================================
  Files          20       20              
  Lines        2041     2030      -11     
==========================================
+ Hits          981      983       +2     
+ Misses       1060     1047      -13     
Files Coverage Δ
src/generate/generate_item.rs 0.00% <0.00%> (ø)
src/generate/impl_for.rs 40.67% <66.66%> (+0.86%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NightEule5 NightEule5 force-pushed the feature/impl-for-trait-generics branch from 591db72 to 2fcd88b Compare November 10, 2023 15:10
@NightEule5 NightEule5 force-pushed the feature/impl-for-trait-generics branch from 2fcd88b to 8b871e9 Compare November 10, 2023 15:14
Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, looks good otherwise

src/generate/impl_for.rs Outdated Show resolved Hide resolved
src/generate/impl_for.rs Outdated Show resolved Hide resolved
src/generate/impl_for.rs Outdated Show resolved Hide resolved
@NightEule5 NightEule5 force-pushed the feature/impl-for-trait-generics branch from 3f58bc6 to cd75149 Compare November 11, 2023 20:09
@NightEule5 NightEule5 force-pushed the feature/impl-for-trait-generics branch from cd75149 to 2369461 Compare November 11, 2023 20:10
@VictorKoenders VictorKoenders merged commit 591ef63 into bincode-org:trunk Nov 12, 2023
7 checks passed
@VictorKoenders
Copy link
Contributor

Thanks!

@NightEule5 NightEule5 deleted the feature/impl-for-trait-generics branch November 14, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generic argument to implemented trait?
2 participants