Resolve remaining test failures for schema validator #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1958 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 91 91
Lines 3792 3792
Branches 1220 1220
=======================================
Hits 3249 3249
Misses 457 457
Partials 86 86 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
schema-provisional
branch
4 times, most recently
from
d566d22 to
324861a
Compare
effigies
force-pushed
the
schema-provisional
branch
from
324861a to
c5bba92
Compare
This test is a bit weird; it seems to have been relying on arbitrary pruning. There's nothing in the rules or code that now (as of #1940) should prevent multiple rules from being returned. If we do want a test to verify pruning, we should come up with a new one.
…notypes' into schema-provisional
effigies
force-pushed
the
schema-provisional
branch
from
c5bba92 to
fffc35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges:
This pulls in the schema from
And this pulls in examples with fixes in
Locally, tests are passing. Let's see what CI says.
masterhave allowed this to be dropped from this PR.