Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno testing 101: deno_tests.yml is chronically red, "on purpose"? #1935

Closed
yarikoptic opened this issue Apr 18, 2024 · 4 comments
Closed

deno testing 101: deno_tests.yml is chronically red, "on purpose"? #1935

yarikoptic opened this issue Apr 18, 2024 · 4 comments
Labels
schema

Comments

@yarikoptic
Copy link
Contributor

seems like just 2 tests are failing... why then to not just xfail/skip them since otherwise sounds like no point of having that CI since it would mask new fails ...
@effigies
Copy link
Collaborator

Yeah, we should probably mark xfails at this point. The goal was for it not to go on so long.

@effigies
Copy link
Collaborator

Nearly resolved for Ubuntu tests: https://github.com/bids-standard/bids-validator/pull/1958

Need to figure out the Mac and Windows tests.

@yarikoptic
Copy link
Contributor Author

thanks -- that is great!

are those the tests on bids-examples and thus may be would allow to remove this skips I added to https://github.com/bids-standard/bids-examples/pull/435/files#diff-786f1d799afd8d7a2bd595ebff633b3683d87a556ec6abfa78bd537855ebe1a0R106 ?

@effigies
Copy link
Collaborator

Yes, it covers all tests, including examples. Some issues on Mac and Windows.

@effigies effigies closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
schema
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarikoptic @effigies