Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HED as optional column for other TSV files #1876

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Jan 4, 2024

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7108f45) 85.43% compared to head (ad9e821) 85.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1876   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         131      131           
  Lines        6269     6269           
  Branches     1524     1524           
=======================================
  Hits         5356     5356           
  Misses        806      806           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good --- except I don't see samples.tsv and samples.json in this list. Thx!

@VisLab
Copy link
Member

VisLab commented Jan 4, 2024 via email

@sappelhoff
Copy link
Member Author

Also, I am wondering about the phenotype entry. The phenotype is a directory and the requirement is that phenotype/*.tsv should have a participant_id.

You are right about this. There is no phenotype.tsv ... only a phenotype/<whatever-name>.tsv.

I will merge this here and open a new issue.

@sappelhoff sappelhoff merged commit 2d923f5 into master Feb 21, 2024
30 of 33 checks passed
@sappelhoff sappelhoff deleted the customCols branch February 21, 2024 09:37
@sappelhoff
Copy link
Member Author

This looks good --- except I don't see samples.tsv and samples.json in this list. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants