-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HED column in tsv file should not give a warning #1875
Comments
I don't understand this point. If you would include an I opened https://github.com/bids-standard/bids-validator/pull/1876 anyhow, to show how the request here could be fulfilled. |
The warning refers to HED as a column name. This would require a json file:
{
"HED": "Blah blah"
}
but the syntax for HED in BIDS requires that HED be at the same level as
"Levels" under a column name:
{
"Column_name1": {
"Levels": { .....}
"HED": { .....}
}
"Column_name2": {
"HED": "Label/#"
}
}
If the first example is used and "HED" appears at the first level, the HED
validator will rightfully detect it as an error.
…On Thu, Jan 4, 2024 at 4:24 AM Stefan Appelhoff ***@***.***> wrote:
However, HED cannot syntactically appear as a top-level key in the JSON
file without triggering an error.
I don't understand this point. If you would include an HED column in a
participants.tsv file, why would you not be able to place a HED key
inside a participants.json file?
I opened #1876 <https://github.com/bids-standard/bids-validator/pull/1876>
anyhow, to show how the request here could be fulfilled.
—
Reply to this email directly, view it on GitHub
<https://github.com/bids-standard/bids-validator/issues/1875#issuecomment-1876853584>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCJOVK45KTG4TR27W6OW3YMZ7NJAVCNFSM6AAAAABBMBPTQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWHA2TGNJYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bids-validator 1.14.0 gives a warning if a HED column appears in a
.tsv
file other than anevents.tsv
file:HED can be usefully included in any
.tsv
file, but particularlyparticipants.tsv
andscans.tsv
, and it is our understanding that the BIDS specification allows this. However, HED cannot syntactically appear as a top-level key in the JSON file without triggering an error.Would it be possible to exclude HED from the listing of missing custom column definitions?
P.S. HED currently in the bids-validator appears to validate the
participants.tsv
andscans.tsv
files okay. We are still working onmotion
,phenotype
andsamples
related.tsv
files.Our demo example is available at: eeg_ds003645s_hed_demo. Once everything is working, we'll be able to replace a number of HED examples on
bids-examples
with a single demo that shows a lot of different uses.@sappelhoff @effigies @rwblair @happy5214
The text was updated successfully, but these errors were encountered: