Add spatial reference frame info to channels.json file #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid redundancy in channels.json
|
@JuliusWelzel can you please review this and tell me if it's good to go? Thanks! |
JuliusWelzel
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Looks good to me and matches the latest specifications and examples presented in the specifications. Only the fields LongName and Description seem to be redundant for now, but might be useful in the future. If *_channels.json in the motion dir gets more fields, an explanation seems helpful.
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the proposed changes in the specification:
... include reference frame description to
*_channels.jsonfile and add column "reference_frame" in*_channels.tsv.