Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect if terminal supports ANSI #103

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Detect if terminal supports ANSI #103

merged 1 commit into from
Aug 26, 2024

Conversation

kornelski
Copy link
Contributor

Fixes #94

@kornelski kornelski mentioned this pull request Aug 8, 2024
Closed
@kornelski kornelski mentioned this pull request Aug 18, 2024
Closed
robtfm
robtfm approved these changes Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@robtfm robtfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me. i am not very familiar with what configurations should use color, but this seems like an improvement.

@kornelski
Copy link
Contributor Author

What's the path to merging this?

@alice-i-cecile alice-i-cecile merged commit 797bf59 into bevyengine:master Aug 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robtfm robtfm robtfm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ANSI output used with non-ANSI terminals, NO_COLOR
3 participants
@kornelski @alice-i-cecile @robtfm