Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI output used with non-ANSI terminals, NO_COLOR #94

Closed
kornelski opened this issue Jun 20, 2024 · 2 comments · Fixed by #103
Closed

ANSI output used with non-ANSI terminals, NO_COLOR #94

kornelski opened this issue Jun 20, 2024 · 2 comments · Fixed by #103

Comments

@kornelski
Copy link
Contributor

I'm running my Bevy projects via Sublime Text, which doesn't have a real terminal, only a super basic plaintext log.

The problem is that naga_oil uses ANSI colors on non-WASM targets unconditionally, without checking whether the terminal is compatible. In my case TERM is undefined, and I'm running std::env::set_var("NO_COLOR", "1") in main, but I still get ANSI color output that makes WGSL errors completely unreadable:

Screenshot 2024-06-21 at 00 17 24
@robtfm
Copy link
Collaborator

robtfm commented Aug 6, 2024

i don't understand this well enough to fix it but a pr would be welcome.

kornelski added a commit to kornelski/temp-pr-naga that referenced this issue Aug 8, 2024
@kornelski
Copy link
Contributor Author

@robtfm submitted a fix in #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants