flipping texture coords methods has been added to the StandardMaterial #12917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugsweeper
force-pushed
the
add-flip-to-standardmaterial
branch
from
98fdc6f to
e797807
Compare
|
@alice-i-cecile May I ask you for a review? |
BD103
added
C-Feature
BD103
suggested changes
Apr 10, 2024
| /// Flip the texture coordinates of the material. | ||
| pub fn flip(&mut self, horizontal: bool, vertical: bool) { | ||
| if horizontal { | ||
| self.uv_transform = Self::FLIP_HORIZONTAL * self.uv_transform; |
There was a problem hiding this comment.
Suggested change
| self.uv_transform = Self::FLIP_HORIZONTAL * self.uv_transform; | |
| self.uv_transform *= Self::FLIP_HORIZONTAL; |
Affine implements MulAssign, so you can do this instead.
There was a problem hiding this comment.
I think this replacement is not correct, because MulAssign will make equivalent of self.uv_transform = self.uv_transform * Self::FLIP_HORIZONTAL; but not self.uv_transform = Self::FLIP_HORIZONTAL * self.uv_transform;. The order is important for vector math. If somebody chain flipped() for StandardMaterial instance, he would expect that flipping transform would be done after original uv_transform, not before
There was a problem hiding this comment.
I see. Could you add a comment explaining why the order is important, then? I could see this being confusing to others.
BD103
approved these changes
Apr 10, 2024
Co-authored-by: BD103 <[email protected]>
alice-i-cecile
approved these changes
Apr 10, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #11996
The deprecated shape Quad's flip field role migrated to StandardMaterial's flip/flipped methods
Solution
flip/flipping methods of StandardMaterial is applicable to any mesh
Changelog
Migration Guide
Instead of using
Quad::flipfield, callflipped(true, false)method on the StandardMaterial instance when adding the mesh.