Add some missing migration guides from older PRs #1850
Conversation
| if let Some(pr) = prs.last() { | ||
| if let Some(datetime_utc) = datetime_utc { | ||
| if let Some(closed_at) = pr.closed_at { | ||
| if closed_at < datetime_utc { |
There was a problem hiding this comment.
This data seems to be unreliable, and early filtering here doesn't actually do us any good.
There was a problem hiding this comment.
I agree that this filtering seems pointless
…ile/bevy-website into old-migration-guides
There was a problem hiding this comment.
This seems to make sense. Included PRs are already filtered by the list of commits. Filtering PRs is just an optimization and it seems broken.
I guess i the future we would want to eventually collect a list of PR numbers and retrieve those specific PRs via the graphql API if possible.
| if let Some(pr) = prs.last() { | ||
| if let Some(datetime_utc) = datetime_utc { | ||
| if let Some(closed_at) = pr.closed_at { | ||
| if closed_at < datetime_utc { |
There was a problem hiding this comment.
I agree that this filtering seems pointless
| let prs = client.get_issues_and_prs( | ||
| BevyRepo::Bevy, | ||
| IssueState::Merged, | ||
| Some(base_commit_date), |
There was a problem hiding this comment.
It's not totally clear to me why this helps, based on GH's documentation about the since param in their API, but it does seem to cause more stuff to get generated.
There was a problem hiding this comment.
Yeah, that was my impression too :(
Part of #1831. Fixes #1518. While this didn't hit all of the missed PRs, the remaining PRs seem to be renames, and are few enough that they can be manually handled.
Like before, I'm aiming to merge these so-so migration guides as is, and then fix up their content in other PRs. There are still PRs that were absolutely missed: I don't see a better way than manually adding the remaining breaking changes for this cycle.