-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog and contributors tools can fail to find PRs #1518
Comments
The older PRs may have to be fetched by id. |
Cutting from the milestone. This is still important to do, but I did them manually this time around. |
In #1850, I'm no longer filtering the PRs by date. This helps: we found another half-dozen PRs! It doesn't fully resolve the mismatch though :( Dozens of PRs were still not found. |
We're using a title match to correlate commits against PRs. In some cases, like bevyengine/bevy#15320, that's definitely because we renamed the PR after it was merged, so the commit name and the PR title don't match. I have no good ideas for how to resolve that. But there's dozens of other PRs, which seemingly don't share that problem. See bevyengine/bevy#14122 for example. The PR exists, it hasn't been renamed. Perhaps there's another date check that I'm missing? |
And by querying for all PRs and trying to match them, I get a much smaller list. PR not found for bevy_reflect: Reflect remote types sha: 6183b56b5d6fd7e2e8cf1f3c85da7fd3dab25ea4
PR not found for Add `condition_changed` and `condition_became_true` to `common_conditions` sha: 12f005a024c163333455bfd8112893c6a8075716
PR not found for Depreciate `LoadAndSave` Asset Processor sha: dac4a5bbb4336527ffd0880233b92f5bc4f93c54
PR not found for bevy_reflect: Add `Reflectable` trait sha: 69541462c5ef70914fd719fcd1f503045c76a453
PR not found for The Cooler 'Retain Rendering World' sha: 56f8e526dde49b4e4ad62efb7ad27bfe0bd6f617 |
Discovered in #1516 / #1517.
The text was updated successfully, but these errors were encountered: