Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog and contributors tools can fail to find PRs #1518

Closed
alice-i-cecile opened this issue Jul 4, 2024 · 5 comments · Fixed by #1850
Closed

Changelog and contributors tools can fail to find PRs #1518

alice-i-cecile opened this issue Jul 4, 2024 · 5 comments · Fixed by #1850
Labels
A-Migration Guides A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site D-Modest S-Ready-For-Implementation The core questions are answered: just add code

Comments

@alice-i-cecile
Copy link
Member

IMO: all of the missed PRs look like they got excluded because they were originally opened before the "from" date for the release

Discovered in #1516 / #1517.

@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code C-Automation Tools to make repetitive tasks easier labels Jul 4, 2024
@ChristopherBiscardi
Copy link
Contributor

get_issues_and_prs gets all PRs since the origin date, which is going to be roughly 0.<last_major>.1's date. That set of PRs is what is is checked so any PR opened before that will not be included because the issues endpoint can not be sorted by "closed date". I believe the default sorting for the issues endpoint is "id, descending".

The older PRs may have to be fetched by id.

@alice-i-cecile
Copy link
Member Author

Cutting from the milestone. This is still important to do, but I did them manually this time around.

@alice-i-cecile
Copy link
Member Author

In #1850, I'm no longer filtering the PRs by date. This helps: we found another half-dozen PRs! It doesn't fully resolve the mismatch though :( Dozens of PRs were still not found.

@alice-i-cecile
Copy link
Member Author

We're using a title match to correlate commits against PRs. In some cases, like bevyengine/bevy#15320, that's definitely because we renamed the PR after it was merged, so the commit name and the PR title don't match. I have no good ideas for how to resolve that.

But there's dozens of other PRs, which seemingly don't share that problem. See bevyengine/bevy#14122 for example. The PR exists, it hasn't been renamed. Perhaps there's another date check that I'm missing?

@alice-i-cecile
Copy link
Member Author

And by querying for all PRs and trying to match them, I get a much smaller list.

PR not found for bevy_reflect: Reflect remote types sha: 6183b56b5d6fd7e2e8cf1f3c85da7fd3dab25ea4
PR not found for Add `condition_changed` and `condition_became_true` to `common_conditions` sha: 12f005a024c163333455bfd8112893c6a8075716
PR not found for Depreciate `LoadAndSave` Asset Processor sha: dac4a5bbb4336527ffd0880233b92f5bc4f93c54
PR not found for bevy_reflect: Add `Reflectable` trait sha: 69541462c5ef70914fd719fcd1f503045c76a453
PR not found for The Cooler 'Retain Rendering World' sha: 56f8e526dde49b4e4ad62efb7ad27bfe0bd6f617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site D-Modest S-Ready-For-Implementation The core questions are answered: just add code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants