Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: stop motors on save while testing #4188

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix: stop motors on save while testing #4188

merged 1 commit into from
Oct 2, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 28, 2024 •
edited
Loading

@haslinghuis haslinghuis added this to the 11.0 milestone Sep 28, 2024
@haslinghuis haslinghuis self-assigned this Sep 28, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 28, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 19159b1
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66fc92f6d49d8d0008257483
😎 Deploy Preview https://deploy-preview-4188.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis changed the title Fix motor Fix motor telemetry warning Sep 28, 2024
@McGiverGim

This comment was marked as outdated.

Sign in to view
@nerdCopter nerdCopter self-requested a review September 30, 2024 14:20
@haslinghuis

This comment was marked as outdated.

Sign in to view
@haslinghuis haslinghuis changed the title Fix motor telemetry warning Fix motor Sep 30, 2024
@haslinghuis haslinghuis marked this pull request as draft October 1, 2024 11:52
@haslinghuis haslinghuis marked this pull request as ready for review October 1, 2024 22:46
@haslinghuis haslinghuis changed the title Fix motor Fix: stop motors on save while testing Oct 1, 2024
@haslinghuis haslinghuis mentioned this pull request Oct 1, 2024
Closed
@haslinghuis haslinghuis requested review from McGiverGim, blckmn and VitroidFPV and removed request for ctzsnooze and VitroidFPV October 1, 2024 23:51
@haslinghuis
Copy link
Member Author

Added

image

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis merged commit bcdd15c into betaflight:master Oct 2, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-motor branch October 2, 2024 00:31
demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
@haslinghuis @demvlad
Fix: stop motors on save while testing (betaflight#4188)
f467a9e 
Stop motors on save
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@VitroidFPV VitroidFPV Awaiting requested review from VitroidFPV

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

Switching from motors tab and back resets the motor status
4 participants
@haslinghuis @McGiverGim @blckmn @nerdCopter