-
-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add positional DOP to GUI #3857
Conversation
haslinghuis
commented
Mar 24, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Not sure what this will show ? |
@haslinghuis thank you very much! TESTED: It works great! The only thing to consider is that in the UBlox documentation, the value they describe is 100 times smaller than what we use. For instance, a value of 220 in our code means a pDOP of 2.20 in UBLox terms. The 'meaning' of 2.2 in UBLox terms is that the expected 3D accuracy should be within 2.2 times the specified accuracy of the module. If module accuracy is specified as +/- 1.5m, then we would expect accuracy within 2.2 * 1.5m. Hence it would be nice to format the value 220 as 2.20, if possible. In the image below, 1.43. |
If this is right, do we have a value going from 0 to 5 ? |
❌ Deploy Preview for origin-betaflight-configurator failed.
|
Quality Gate passedIssues Measures |
❌ Deploy Preview for origin-betaflight-configurator failed.
|
Do you want to test this code? Here you have an automated build: |
@haslinghuis my propsal was if value best shown as 'slider' from 0 to 5, just for better view (or I myself can try another day :-) ) |
For now it displays the same PDOP value as the OSD. We are looking into other fields for better presentation. This PR should be ready now. |
|
* Display positional DOP * Fix DOP presentation