Add positional DOP to GUI (betaflight#3857)

* Display positional DOP * Fix DOP presentation
chmelevskij · Apr 27, 2024 · e429c68 · e429c68
1 parent 819cabc
commit e429c68
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 0 deletions.
diff --git a/locales/en/messages.json b/locales/en/messages.json
@@ -2839,6 +2839,9 @@
     "gpsDistToHome": {
         "message": "Dist to Home:"
     },
+    "gpsPositionalDop": {
+        "message": "Positional DOP:"
+    },
     "gpsSignalStrHead": {
         "message": "GPS Signal Strength"
     },

diff --git a/src/js/VirtualFC.js b/src/js/VirtualFC.js
@@ -260,6 +260,7 @@ const sampleGpsData = {
     "alt": 0,
     "speed": 0,
     "ground_course": 1337,
+    "positionalDop": 0,
     "distanceToHome": 0,
     "directionToHome": 0,
     "update": 0,

diff --git a/src/js/fc.js b/src/js/fc.js
@@ -306,6 +306,7 @@ const FC = {
             alt:                        0,
             speed:                      0,
             ground_course:              0,
+            positionalDop:              0,
             distanceToHome:             0,
             directionToHome:            0,
             update:                     0,

diff --git a/src/js/msp/MSPHelper.js b/src/js/msp/MSPHelper.js
@@ -295,6 +295,9 @@ MspHelper.prototype.process_data = function(dataHandler) {
                 FC.GPS_DATA.alt = data.readU16();
                 FC.GPS_DATA.speed = data.readU16();
                 FC.GPS_DATA.ground_course = data.readU16();
+                if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46)) {
+                    FC.GPS_DATA.positionalDop = data.readU16();
+                }
                 break;
             case MSPCodes.MSP_COMP_GPS:
                 FC.GPS_DATA.distanceToHome = data.readU16();

diff --git a/src/js/tabs/gps.js b/src/js/tabs/gps.js
@@ -242,6 +242,13 @@ gps.initialize = async function (callback) {
             $('.GPS_info td.sats').text(FC.GPS_DATA.numSat);
             $('.GPS_info td.distToHome').text(`${FC.GPS_DATA.distanceToHome} m`);
 
+            if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46)) {
+                const positionalDop = FC.GPS_DATA.positionalDop / 100;
+                $('.GPS_info td.positionalDop').text(`${positionalDop.toFixed(2)}`);
+            } else {
+                $('.GPS_info td.positionalDop').parent().hide();
+            }
+
             // Update GPS Signal Strengths
             const eSsTable = $('div.GPS_signal_strength table');
 

diff --git a/src/tabs/gps.html b/src/tabs/gps.html
@@ -118,6 +118,10 @@
                                 <td i18n="gpsDistToHome"></td>
                                 <td class="distToHome"></td>
                             </tr>
+                            <tr>
+                                <td i18n="gpsPositionalDop"></td>
+                                <td class="positionalDop"></td>
+                            </tr>
                         </table>
                     </div>
                 </div>