Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix /usr/bin/env: 'node\r': No such file or directory #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryantate13
Copy link

Use Unix line endings on cli.js to fix crash on Linux

@glensc
Copy link

glensc commented Aug 12, 2018

indeed. this is problem on linux.

$ /usr/local/bin/subdownload
: No such file or directory

cc @beatfreaker

@glensc
Copy link

glensc commented Aug 12, 2018

the #8 fix is bogus and doesn't fix anything

@glensc
Copy link

glensc commented Aug 12, 2018

merging this would also close #3 and #4

but the maintainer has to publish new npm version

@glensc
Copy link

glensc commented Aug 12, 2018

seems the @ryantate13 fix also doesn't change anything. just renames file two times.

i'll submit another PR with the proper fix

@glensc
Copy link

glensc commented Aug 12, 2018

hmm. seems the problem is the way release is made. the cli.js is ok in repository, just when checkouted on windows and released from there, the files end up with DOS EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants