Add scheduled entry time of the day #337
Conversation
Probably this `t` was forgotten here. This function asks for time-stamp format, For sure when users include a time of the day there, they would like to have it included in the timestamp.
Currently the command inserts the time preceding the TODO. This PR implements fixes (non-desctructively), but it assumes that bastibe#335 and bastibe#337 get merged first.
Currently the command inserts the time preceding the TODO. This PR implements fixes (non-desctructively), but it assumes that bastibe#335 and bastibe#337 get merged first.
Currently the command inserts the time preceding the TODO. This PR implements fixes (non-desctructively), but it assumes that bastibe#335 and bastibe#337 get merged first.
That was actually on purpose. The I'm fine with including the "hour:minute". But the tests need than to be adjusted too. This change seem to break the CI. |
|
Could you specify which tests should get adjusted and how this breaks the CI? Of course this only adds the time to the time-stamp, which would be a great option to have for using it with org-wild-notifier (besides that it would be nice to have the option to schedule for a specific time instead of for a specific day only). If it breaks something we could just make it an option via an extra argument (and then make a separate command that calls this function with that extra argument, just like how the extra command for inserting at point was created in #335). |
|
org-journal/tests/org-journal-test.el Line 293 in 919abc9 |
|
I have fixed the test and merge this PR. |
|
Haha! I just wanted to push a fix also. But anyway great! Thanks for merging. Let me know if you have some questions about the other PR's, or if you would like me to add some extra comments to save you time from figuring out their purpose. |
Probably this
twas forgotten here. This function asks for time-stamp format, For sure when users include a time of the day there, they would like to have it included in the timestamp.