-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org wild notifier to org layer #14418
Add org wild notifier to org layer #14418
Conversation
0fbd49a
to
1a43077
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from that the new package should be deferred.
Can you close your old PR if it is not longer needed?
1a43077
to
c667758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will be merged soon.
@dalanicolai looks like there are some conflicts in your PR, can you have a look? Especially there is a merge which prevents me from cherry picking your commit. Can you squash/fix the conflicts on your side? |
c667758
to
cc26b86
Compare
This PR should be a better replacement for syl20bnr#14396. See the last comment of that PR for motivation.
cc26b86
to
683fb72
Compare
@smile13241324 Ah sorry. I am still no git expert. To create the Therewere some more git horrors when I tried to rebase, because somehow it did not leave my 'fix branch' intact. Anyway. I have applied some tricks now to fix it. I hope I have done things more or less correctly now. Thanks again of course! |
Thank you for contributing to spacemacs 💜, I have cherry picked your commit into develop. |
The documentation part in this PR assumes that bastibe/org-journal#339 got merged, which did not happen yet. But, although I expected it to get merged sooner, I still expect it to get merged very soon (probably before anybody will discover this documentation about those |
This PR replaces #14396. See last comments there for motivation.
I've added instructions to use =org-journal-new-scheduled-entry=, assuming that PR numbers 335, 337 and 338 get merged soon.