Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cantina contest report #1181

Merged
merged 5 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions audits/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,13 @@ The audits have been conducted before the [Cantina contest](https://cantina.xyz/
| Scope | Firm | Report |
| --------------------------------- | ------------- | ---------------------------------------------------- |
| Vault, Weighted Pool, Stable Pool | Certora | [`2024-09-04`](./certora/2024-09-04.pdf) |
| Vault, Weighted Pool, Stable Pool | Trail Of Bits | [`2024-12-11`](./trail-of-bits/2024-12-11.pdf) |
| Vault, Weighted Pool, Stable Pool | Spearbit* | [`2024-10-04`](./spearbit/2024-10-04.pdf) |

| Vault, Weighted Pool, Stable Pool | Trail Of Bits | [`2024-10-08`](./trail-of-bits/2024-10-08.pdf) |
| Vault, Weighted Pool, Stable Pool | Spearbit<sup>1</sup> | [`2024-10-04`](./spearbit/2024-10-04.pdf) |
| Pre-competition v3 codebase | Cantina<sup>2</sup> | [`2024-12-17`](./cantina/2024-12-17.pdf) |
| Post-competition v3 codebase | Cantina<sup>2</sup> | [`2024-12-31`](./cantina/2024-12-31.pdf) |

## Addenda
* Note that 5.2.6 in the Spearbit audit of 2024-10-04 was resolved after the date of the audit. [PR #1113](https://github.com/balancer/balancer-v3-monorepo/pull/1113) replaces the event with explicit add/remove liquidity events, and accounts for swap fees in a separate field.

<sup>1</sup> Note that 5.2.6 in the Spearbit audit of 2024-10-04 was resolved after the date of the audit. [PR #1113](https://github.com/balancer/balancer-v3-monorepo/pull/1113) replaces the event with explicit add/remove liquidity events, and accounts for swap fees in a separate field.

<sup>2</sup> See [this page](https://cantina.xyz/competitions/949ad7c5-ea14-427d-b10a-54e33cef921b) for the description of the competition. The target was a pre-launch version of the codebase at [this commit](https://github.com/balancer/balancer-v3-monorepo/commit/147823666ff6556de2a01c6762ed688ab81a6a33). The follow-up post-competition review was performed on a [fork](https://github.com/cantina-forks/balancer-v3-monorepo/tree/73708b75898a62dac0535f38d1bf471ac0e538c6/) of the code after fixes (from 11/24/24, still pre-launch code). The final deployed v3 codebase contained fixes for all known issues.
Binary file added audits/cantina/2024-12-17.pdf
Binary file not shown.
Binary file added audits/cantina/2024-12-31.pdf
Binary file not shown.
Loading