Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cantina contest report #1181

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Add Cantina contest report #1181

merged 5 commits into from
Jan 3, 2025

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Dec 16, 2024

Description

PDF from Cantina contest.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

N/A

@jubeira
Copy link
Contributor Author

jubeira commented Dec 17, 2024

Note: this is the draft. Will update with the final one before merging.

@elshan-eth elshan-eth self-requested a review December 17, 2024 13:37
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I added to the readme, and used superscripts instead of "*", "**", in case we have more notes going forward.

Unless you think we don't need this in the readme?

@jubeira
Copy link
Contributor Author

jubeira commented Jan 3, 2025

I think it's fine. Let's just approve and merge this one.

Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jubeira jubeira merged commit 641661b into main Jan 3, 2025
13 checks passed
@jubeira jubeira deleted the cantina-competition branch January 3, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants