Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing action ids for v3 pool weighted #131

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Dec 5, 2024

Description

I was thinking about the pool itself, but forgot about disable in the factory. This PR wraps up V3 weighted pool factory deployment.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb December 5, 2024 15:09
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EndymionJkb EndymionJkb merged commit 422253a into master Dec 5, 2024
30 checks passed
@EndymionJkb EndymionJkb deleted the weighted-pool-action-ids branch December 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants