[BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs #1535

gosuto-inzasheru · 2024-12-02T04:51:23Z

closes #1499
closes #1500

bip draft: https://docs.google.com/document/d/17uaFz-osYWUQlCk7a0ZSZZXj3QIL-LnPPlnmz5AbdQc/

github-actions · 2024-12-02T04:53:07Z

FILENAME: BIPs/2024-W50/[BIP-741] perms_v3_ethereum.json
COMMIT: 55bb116955e3b0842256bd41974bb689e57eef92

Validator	Result
`validate_contains_msig`	✅
`validate_msig_in_address_book`	✅
`validate_chain_specified`	✅
`validate_file_has_bip`	✅
`validate_path_has_weekly_dir`	✅

FILENAME: BIPs/2024-W50/[BIP-741] perms_v3_gnosis.json
COMMIT: 55bb116955e3b0842256bd41974bb689e57eef92

Validator	Result
`validate_contains_msig`	✅
`validate_msig_in_address_book`	✅
`validate_chain_specified`	✅
`validate_file_has_bip`	✅
`validate_path_has_weekly_dir`	✅

github-actions · 2024-12-02T04:53:08Z

FILENAME: BIPs/2024-W50/[BIP-741] perms_v3_ethereum.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: 55bb116955e3b0842256bd41974bb689e57eef92
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20241204-v3-vault/VaultAdmin/setStaticSwapFeePercentage(address,uint256)                      | 0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c | BIP-741 |    0     |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setGlobalProtocolSwapFeePercentage(uint256)           | 0x31893078b6590802f57d29fae81f10113c336375df90db2aed0392af0c75d8d4 |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setGlobalProtocolYieldFeePercentage(uint256)          | 0x3bc669a22fd5eb10a81a9ab00e0cab660e6f703d7ae9185597386bbd2e849e3f |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setProtocolSwapFeePercentage(address,uint256)         | 0x93100e2a70c799f7ba831633b6a5078fc649ca0c812caa633106f1948a819155 |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setProtocolYieldFeePercentage(address,uint256)        | 0x131f9541f99a187d0a0db49756fb64345dec624e21579355e25b8b5a1b40b45c |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/withdrawProtocolFees(address,address)                 | 0x4071255a8a5c23dae545fa9427571cfd2cbc2f7e623e863ec2c917ed09074e43 |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address) | 0xf830de585800a430465649def91ee4e68e52ef19d8734b6836b9a2237853fc07 |         |          |
|                       |                     |                                            | 20241205-v3-stable-pool/StablePool/startAmplificationParameterUpdate(uint256,uint256)         | 0xc1d77fef06a5acef26a30536474b98eb44840e5f17e86114c8aaa4274e206b3c |         |          |
|                       |                     |                                            | 20241205-v3-stable-pool/StablePool/stopAmplificationParameterUpdate()                         | 0xeeed27c13054947e3283c26fca5c34c2e514ef8caa98f1c6a6778c06f1d247da |         |          |
| Authorizer/grantRoles | multisigs/emergency | 0xA29F61256e948F3FB707b4b3B138C5cCb9EF9888 | 20241204-v3-vault/VaultAdmin/pauseVault()                                                     | 0x461c5a059d49bcf53ff00ff0d6fe644f40cc96ff9f6012e75ea70824dba5f886 | BIP-741 |    1     |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/unpauseVault()                                                   | 0xa3cc69d3a95a1b4020228f384f292c33a2db8f395442b06805d5195609d66b4e |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/pausePool(address)                                               | 0xae26501f09c96de9e98977fff0d65a23cb22db73a58ddef38127af1a616cf272 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/unpausePool(address)                                             | 0xa4443105bdb833cb364c9f76caa2adf3c6e62427cb693ffd6f1d8d7f44ad1bb5 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/pauseVaultBuffers()                                              | 0xe80d721d89f2236e9428bfba076cbbbb355faeb9d9b97b49890ebcf930d05bc9 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/unpauseVaultBuffers()                                            | 0xf923c4af23349707476c28766c280b0178ab3c4ebfa546da8c25a546a066a2dc |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/enableRecoveryMode(address)                                      | 0xb1539e3ebdcf854dedf819f6232d1e447cfb129f7bf572e70295fb998bd8c85e |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/disableRecoveryMode(address)                                     | 0x03aef606b4b82495d96af41cf1ed84b739a1de2bfb37bc1c0cfde2c53cf096aa |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/enableQuery()                                                    | 0x130ac25c06d0a78c43cee16ed4147a8a2337d8dc08571f397ca9ac15e1fc2ec2 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/disableQuery()                                                   | 0x7b9f4d9b9d0380987936892409571a5e0b6e9b538806ac662699a305304bd15d |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/disableQueryPermanently()                                        | 0x6832812101826d0b63748615617865e97f09b944c344d3bbd7d50b5be617eb16 |         |          |
|                       |                     |                                            | 20241205-v3-stable-pool/StablePoolFactory/disable()                                           | 0x2f54088e4f997de92b7bea3779089047980bab824c65d526fc075413ff373000 |         |          |
|                       |                     |                                            | 20241205-v3-weighted-pool/WeightedPoolFactory/disable()                                       | 0xed6f8a5f0602534601834cae86e16a9424b7bf30c562d15bd781fbcd5026d9a1 |         |          |
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2024-W50/[BIP-741] perms_v3_gnosis.json
MULTISIG: multisigs/dao (gnosis:0x2a5AEcE0bb9EfFD7608213AE1745873385515c18)
COMMIT: 55bb116955e3b0842256bd41974bb689e57eef92
CHAIN(S): gnosis
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20241204-v3-vault/VaultAdmin/setStaticSwapFeePercentage(address,uint256)                      | 0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c | BIP-741 |    0     |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setGlobalProtocolSwapFeePercentage(uint256)           | 0x31893078b6590802f57d29fae81f10113c336375df90db2aed0392af0c75d8d4 |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setGlobalProtocolYieldFeePercentage(uint256)          | 0x3bc669a22fd5eb10a81a9ab00e0cab660e6f703d7ae9185597386bbd2e849e3f |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setProtocolSwapFeePercentage(address,uint256)         | 0x93100e2a70c799f7ba831633b6a5078fc649ca0c812caa633106f1948a819155 |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/setProtocolYieldFeePercentage(address,uint256)        | 0x131f9541f99a187d0a0db49756fb64345dec624e21579355e25b8b5a1b40b45c |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/withdrawProtocolFees(address,address)                 | 0x4071255a8a5c23dae545fa9427571cfd2cbc2f7e623e863ec2c917ed09074e43 |         |          |
|                       |                     |                                            | 20241204-v3-vault/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address) | 0xf830de585800a430465649def91ee4e68e52ef19d8734b6836b9a2237853fc07 |         |          |
|                       |                     |                                            | 20241205-v3-stable-pool/StablePool/startAmplificationParameterUpdate(uint256,uint256)         | 0xd092c49bcc2e34f69b02005821b50d57632951029f4a20eb4fb8d6fcb2ef08a3 |         |          |
|                       |                     |                                            | 20241205-v3-stable-pool/StablePool/stopAmplificationParameterUpdate()                         | 0x66a9e5de1de4dbcb0b1d3979ca06bd4bb8ba535a1f67873ed92779cfd976dcf0 |         |          |
| Authorizer/grantRoles | multisigs/emergency | 0xd6110A7756080a4e3BCF4e7EBBCA8E8aDFBC9962 | 20241204-v3-vault/VaultAdmin/pauseVault()                                                     | 0x461c5a059d49bcf53ff00ff0d6fe644f40cc96ff9f6012e75ea70824dba5f886 | BIP-741 |    1     |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/unpauseVault()                                                   | 0xa3cc69d3a95a1b4020228f384f292c33a2db8f395442b06805d5195609d66b4e |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/pausePool(address)                                               | 0xae26501f09c96de9e98977fff0d65a23cb22db73a58ddef38127af1a616cf272 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/unpausePool(address)                                             | 0xa4443105bdb833cb364c9f76caa2adf3c6e62427cb693ffd6f1d8d7f44ad1bb5 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/pauseVaultBuffers()                                              | 0xe80d721d89f2236e9428bfba076cbbbb355faeb9d9b97b49890ebcf930d05bc9 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/unpauseVaultBuffers()                                            | 0xf923c4af23349707476c28766c280b0178ab3c4ebfa546da8c25a546a066a2dc |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/enableRecoveryMode(address)                                      | 0xb1539e3ebdcf854dedf819f6232d1e447cfb129f7bf572e70295fb998bd8c85e |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/disableRecoveryMode(address)                                     | 0x03aef606b4b82495d96af41cf1ed84b739a1de2bfb37bc1c0cfde2c53cf096aa |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/enableQuery()                                                    | 0x130ac25c06d0a78c43cee16ed4147a8a2337d8dc08571f397ca9ac15e1fc2ec2 |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/disableQuery()                                                   | 0x7b9f4d9b9d0380987936892409571a5e0b6e9b538806ac662699a305304bd15d |         |          |
|                       |                     |                                            | 20241204-v3-vault/VaultAdmin/disableQueryPermanently()                                        | 0x6832812101826d0b63748615617865e97f09b944c344d3bbd7d50b5be617eb16 |         |          |
|                       |                     |                                            | 20241205-v3-stable-pool/StablePoolFactory/disable()                                           | 0x918265b00e10f59d74df8af13287d5465c19a072459da4ae7d94b20d4e66c1e8 |         |          |
|                       |                     |                                            | 20241205-v3-weighted-pool/WeightedPoolFactory/disable()                                       | 0x0b57c528b17bebb5b75282268198cc2f48585d04488cdc16020206499ed61769 |         |          |
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

… reports) + reformat JSON

gosuto-inzasheru · 2024-12-05T05:22:27Z

waiting for deployment of v3-stable-pool to get actions ids for startAmplificationParameterUpdate(uint256,uint256) and stopAmplificationParameterUpdate()

Xeonus · 2024-12-05T15:15:32Z

@gosuto-inzasheru according to @jubeira we should also make sure to add functionality to disable new pool creation via factories as for v2

See PR: balancer/balancer-deployments#131

For currently missing action IDs for stable pools, once this PR is merged we have everything: balancer/balancer-deployments#130

… reports) + reformat JSON

Xeonus

upgrade of workflow OK
bump to bal address dependencies OK
Cross checked mainnet and gnosis chain action IDs and can confirm they all match
Permissions match desired initial set for launch

… reports) + reformat JSON

Xeonus

all still good, bump from dependencies

chore: skeleton payloads for granting perms

e31d463

gosuto-inzasheru temporarily deployed to internal December 2, 2024 04:51 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 2, 2024 04:53

Automated processing of Payload PR (validations, transformations, and…

06e6bb5

… reports) + reformat JSON

Merge branch 'main' into chore/perms_v3

77d284d

gosuto-inzasheru temporarily deployed to internal December 4, 2024 06:21 — with GitHub Actions Inactive

gosuto-inzasheru and others added 4 commits December 4, 2024 06:23

Automated processing of Payload PR (validations, transformations, and…

3ed9d1b

… reports) + reformat JSON

ci: typos in step names

e7f2468

ci: fix numpy by preventing installing numpy>=2.0.0

53d4c51

feat: (draft) permissions mapping for v3 launch

3e1eabc

gosuto-inzasheru temporarily deployed to internal December 4, 2024 07:01 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 4, 2024 07:03

Automated processing of Payload PR (validations, transformations, and…

dba920b

… reports) + reformat JSON

chore: add emergency actions ids for ethereum

9826e6f

gosuto-inzasheru had a problem deploying to internal December 5, 2024 04:30 — with GitHub Actions Failure

gosuto-inzasheru had a problem deploying to internal December 5, 2024 04:33 — with GitHub Actions Failure

ci: v6 introduces breaking changes for our imports

7e9bad9

gosuto-inzasheru temporarily deployed to internal December 5, 2024 04:40 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 04:41

Automated processing of Payload PR (validations, transformations, and…

0f7d4e4

… reports) + reformat JSON

fix: use double quotes

b770b0a

gosuto-inzasheru temporarily deployed to internal December 5, 2024 04:45 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 04:47

Automated processing of Payload PR (validations, transformations, and…

ad27baa

… reports) + reformat JSON

fix: no quotes at all

b26db01

gosuto-inzasheru temporarily deployed to internal December 5, 2024 04:48 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 04:49

Automated processing of Payload PR (validations, transformations, and…

cef0d1a

… reports) + reformat JSON

chore: add more perms

30e49ee

gosuto-inzasheru had a problem deploying to internal December 5, 2024 05:07 — with GitHub Actions Failure

chore: more perms for both ethereum and gnosis

6fa7787

gosuto-inzasheru had a problem deploying to internal December 5, 2024 05:15 — with GitHub Actions Failure

fix: remove comments

3fb63e2

gosuto-inzasheru temporarily deployed to internal December 5, 2024 05:18 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

b880e59

… reports) + reformat JSON

gosuto-inzasheru changed the title ~~chore: skeleton payloads for granting perms~~ feat: grant emergency and maxi msigs perms for v3 Dec 5, 2024

chore: add last missing perms

ddd1805

gosuto-inzasheru temporarily deployed to internal December 5, 2024 17:05 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 17:07

Automated processing of Payload PR (validations, transformations, and…

bcce7af

… reports) + reformat JSON

fix: pool permissions are not the same on gnosis

2c4f7f8

gosuto-inzasheru temporarily deployed to internal December 5, 2024 17:14 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 17:15

Automated processing of Payload PR (validations, transformations, and…

d1b694c

… reports) + reformat JSON

chore: add stable pool disable as well

290c48b

gosuto-inzasheru temporarily deployed to internal December 5, 2024 17:20 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 17:21

Automated processing of Payload PR (validations, transformations, and…

b52b259

… reports) + reformat JSON

chore: assign bip# and move to next week

ceb5dc3

gosuto-inzasheru temporarily deployed to internal December 5, 2024 17:28 — with GitHub Actions Inactive

gosuto-inzasheru and others added 2 commits December 5, 2024 17:29

Automated processing of Payload PR (validations, transformations, and…

aa5ee91

… reports) + reformat JSON

fix: bip needs to be uppercase?

af66bac

gosuto-inzasheru temporarily deployed to internal December 5, 2024 17:33 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

e1336b0

… reports) + reformat JSON

gosuto-inzasheru changed the title ~~feat: grant emergency and maxi msigs perms for v3~~ [BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs Dec 5, 2024

gosuto-inzasheru marked this pull request as ready for review December 9, 2024 04:10

Xeonus previously approved these changes Dec 9, 2024

View reviewed changes

chore: removed unused authorizer script json

55bb116

gosuto-inzasheru dismissed Xeonus’s stale review via 55bb116 December 9, 2024 12:54

gosuto-inzasheru temporarily deployed to internal December 9, 2024 12:54 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

8e845f3

… reports) + reformat JSON

Xeonus approved these changes Dec 9, 2024

View reviewed changes

gosuto-inzasheru merged commit d62f2d4 into main Dec 9, 2024
2 checks passed

gosuto-inzasheru deleted the chore/perms_v3 branch December 9, 2024 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs #1535

[BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs #1535

gosuto-inzasheru commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading

gosuto-inzasheru commented Dec 5, 2024

Xeonus commented Dec 5, 2024

Xeonus left a comment

Xeonus left a comment

[BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs #1535

[BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs #1535

Conversation

gosuto-inzasheru commented Dec 2, 2024 • edited Loading

github-actions bot commented Dec 2, 2024 • edited Loading

github-actions bot commented Dec 2, 2024 • edited Loading

gosuto-inzasheru commented Dec 5, 2024

Xeonus commented Dec 5, 2024

Xeonus left a comment

Choose a reason for hiding this comment

Xeonus left a comment

Choose a reason for hiding this comment

gosuto-inzasheru commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading