Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make room for protocol versions. #122

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Make room for protocol versions. #122

merged 5 commits into from
Dec 3, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Dec 1, 2024

Description

Place existing task / deprecated / scripts under a v2 directory, create a v3 directory for new tasks and adapt scripts.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira marked this pull request as ready for review December 1, 2024 03:06
@jubeira jubeira mentioned this pull request Dec 2, 2024
9 tasks
Copy link
Contributor

@elshan-eth elshan-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step, though I think we will need to refine it later. Maybe there needs to be a way to address v2 or v3. The "global" scripts (e.g., that generate addresses) would run over both v2 and v3, and take a long time. Do we want to reverify v2 every time we deploy a v3 thing? Stuff like that we can think about later. Could even split the readme into two pages: either v2/v3 or pre-/post-v3 launch (e.g., v2 and v3 would be mixed on the post-launch page, but only show v2 things deployed after the v3 launch. All legacy v2 stuff would be in the first page.

@jubeira
Copy link
Contributor Author

jubeira commented Dec 3, 2024

Good first step, though I think we will need to refine it later.

Suggestions and PRs are welcome after launch :)

@jubeira jubeira merged commit 80505f7 into master Dec 3, 2024
30 checks passed
@jubeira jubeira deleted the v3-skeleton branch December 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants