fix: minimal change - handle tasks with v2/v3 in path name in deployments directory sturcture #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory structure. This approach takes a minimal change approach, whereby in the resulting addresbook the v2/v3 directory name is ignored/not present. It assumes that all v3 deployments will start with v3- and we can filter on this. This approach invovles no braking changes to anything that currently runs, but also provides the least structure/information about what belongs to what.
|
Changes to deployments repo:balancer/balancer-deployments#122 Failed action after change to balancer-deployments: https://github.com/BalancerMaxis/bal_addresses/actions/runs/12148001865/job/33875992424 Test action run on this branch: https://github.com/BalancerMaxis/bal_addresses/actions/runs/12148515698 |
|
Resulting PR: #530 This looks good, everything is the same except recent changes. |
gosuto-inzasheru
approved these changes
Dec 4, 2024
gosuto-inzasheru
deleted the
fix/minimal_adaption_deployments_directory_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach takes a minimal change approach, whereby in the resulting addresbook the v2/v3 directory name is ignored/not present. It assumes that all v3 deployments will start with v3- and we can filter on this. This approach invovles no braking changes to anything that currently runs, but also provides the least structure/information about what belongs to what.