Fix substitution #449

sujuka99 · 2024-02-06T06:59:37Z

closes #448

- schema_registry_url - schemaRegistryUrl

48459ee 'Improve performance'

during enrich we should not validate

d4efc48 'Remove from & to section from Kafka app cleaner' c6bfbbc 'Update snapshot' 9283043 'Remove from & to section from Connector resetter' c76f072 'Update snapshots'

kpops/pipeline.py

kpops/utils/gen_schema.py

sujuka99

@disrupted thanks for the explanations :)
LGTM

tests/conftest.py

tests/pipeline/resources/resetter_values/defaults.yaml

tests/pipeline/resources/resetter_values/pipeline.yaml

test: minimal example

f71da2a

sujuka99 added type/bug component/generator Related to the generation of pipeline.yaml labels Feb 6, 2024

sujuka99 added this to the Hardening KPOps milestone Feb 6, 2024

sujuka99 self-assigned this Feb 6, 2024

sujuka99 and others added 20 commits February 6, 2024 17:49

Improve tests

c59efee

add much more minimal example

0d3eb25

fix eof

634ed0c

fix: substitution timing WIP

4e48966

Test using Python API

35fd009

Run the actual assertion

e7722ed

Fix assertions

b0e029c

Implement fix

1ff50e0

Cosmetic

169110e

Fix pipeline_{environment}.yaml override

2737a18

Fix double schema registry url

1157aec

- schema_registry_url - schemaRegistryUrl

Try model_dump without by_alias=True

052a7c2

Fix Ruff diagnostics

d0cbbbc

Fix schema generation

df84620

Fix Ruff

986ab45

Fix substitution var notation in tests

d91787d

Update test

04ac93e

Refactor

5c89efe

Improve performance

48459ee

Mark todo

2e5f543

sujuka99 changed the title ~~Fix inflation~~ Fix substitution Feb 7, 2024

disrupted added 4 commits February 7, 2024 09:44

Fix KafkaConnector test

f49fcef

Revert 1 commits

588d668

48459ee 'Improve performance'

Refactor & mark todo

fde7a54

Run substitute twice to fix test

52678b2

disrupted added 10 commits February 7, 2024 13:18

Fix validation too early

6a1f153

during enrich we should not validate

Update snapshots

c39d636

Cleanup arguments

47b27c1

Rename tmp self

d7709f1

Cleanup

d108fd1

Remove from & to section from Kafka app cleaner

d4efc48

Update snapshot

c6bfbbc

Remove from & to section from Connector resetter

9283043

Update snapshots

c76f072

Revert 4 commits

6b2a56c

d4efc48 'Remove from & to section from Kafka app cleaner' c6bfbbc 'Update snapshot' 9283043 'Remove from & to section from Connector resetter' c76f072 'Update snapshots'

sujuka99 mentioned this pull request Feb 7, 2024

Fix nested substitution #451

Merged

disrupted and others added 4 commits February 7, 2024 16:37

Cosmetic

c7f1868

remove duplicated substitution function

cbd1172

Remove redundant test.

cfc7676

Unused import

3c9bf3e

sujuka99 commented Feb 8, 2024

View reviewed changes

kpops/pipeline.py Show resolved Hide resolved

kpops/utils/gen_schema.py Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into fix/inflate-substitution

f4c6339

sujuka99 marked this pull request as ready for review February 8, 2024 09:12

sujuka99 requested review from raminqaf and irux as code owners February 8, 2024 09:12

sujuka99 commented Feb 8, 2024

View reviewed changes

disrupted reviewed Feb 8, 2024

View reviewed changes

tests/conftest.py Show resolved Hide resolved

tests/pipeline/resources/resetter_values/defaults.yaml Outdated Show resolved Hide resolved

sujuka99 and others added 2 commits February 8, 2024 11:17

Remove leftover comments.

42b6d46

Merge branch 'main' into fix/inflate-substitution

2d83e7f

disrupted reviewed Feb 8, 2024

View reviewed changes

tests/pipeline/resources/resetter_values/pipeline.yaml Outdated Show resolved Hide resolved

Fix custom component name

094c714

disrupted approved these changes Feb 8, 2024

View reviewed changes

sujuka99 merged commit d306e3d into main Feb 8, 2024
7 checks passed

sujuka99 deleted the fix/inflate-substitution branch February 8, 2024 09:50

disrupted self-assigned this Feb 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix substitution #449

Fix substitution #449

sujuka99 commented Feb 6, 2024

sujuka99 left a comment •

edited

Loading

Fix substitution #449

Fix substitution #449

Conversation

sujuka99 commented Feb 6, 2024

sujuka99 left a comment • edited Loading

Choose a reason for hiding this comment

sujuka99 left a comment •

edited

Loading