Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested substitution #451

Merged
merged 14 commits into from
Feb 12, 2024
Merged

Fix nested substitution #451

merged 14 commits into from
Feb 12, 2024

Conversation

sujuka99
Copy link
Contributor

@sujuka99 sujuka99 commented Feb 7, 2024

No description provided.

@sujuka99 sujuka99 self-assigned this Feb 7, 2024
@sujuka99 sujuka99 marked this pull request as ready for review February 9, 2024 15:57
@sujuka99
Copy link
Contributor Author

sujuka99 commented Feb 9, 2024

I tried hard, but couldn't come up with a sensible way to combine the 2 functions. All suggestions/ideas are welcome :)

kpops/utils/yaml.py Outdated Show resolved Hide resolved
kpops/utils/yaml.py Show resolved Hide resolved
tests/components/test_base_defaults_component.py Outdated Show resolved Hide resolved
@sujuka99 sujuka99 requested a review from disrupted February 12, 2024 12:56
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make a patch release

@sujuka99 sujuka99 merged commit e09fc03 into main Feb 12, 2024
6 of 7 checks passed
@sujuka99 sujuka99 deleted the fix/nested-substitution branch February 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants