-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: granular delegation states #135
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
package v2types | ||
|
||
import ( | ||
"fmt" | ||
|
||
indexertypes "github.com/babylonlabs-io/staking-api-service/internal/indexer/types" | ||
) | ||
|
||
// DelegationState represents the flattened state for frontend consumption | ||
type DelegationState string | ||
|
||
const ( | ||
// Basic states | ||
StatePending DelegationState = "PENDING" | ||
StateVerified DelegationState = "VERIFIED" | ||
StateActive DelegationState = "ACTIVE" | ||
|
||
// Unbonding states | ||
StateTimelockUnbonding DelegationState = "TIMELOCK_UNBONDING" | ||
StateEarlyUnbonding DelegationState = "EARLY_UNBONDING" | ||
|
||
// Withdrawable states | ||
StateTimelockWithdrawable DelegationState = "TIMELOCK_WITHDRAWABLE" | ||
StateEarlyUnbondingWithdrawable DelegationState = "EARLY_UNBONDING_WITHDRAWABLE" | ||
StateTimelockSlashingWithdrawable DelegationState = "TIMELOCK_SLASHING_WITHDRAWABLE" | ||
StateEarlyUnbondingSlashingWithdrawable DelegationState = "EARLY_UNBONDING_SLASHING_WITHDRAWABLE" | ||
|
||
// Withdrawn states | ||
StateTimelockWithdrawn DelegationState = "TIMELOCK_WITHDRAWN" | ||
StateEarlyUnbondingWithdrawn DelegationState = "EARLY_UNBONDING_WITHDRAWN" | ||
StateTimelockSlashingWithdrawn DelegationState = "TIMELOCK_SLASHING_WITHDRAWN" | ||
StateEarlyUnbondingSlashingWithdrawn DelegationState = "EARLY_UNBONDING_SLASHING_WITHDRAWN" | ||
|
||
// Slashed states | ||
StateTimelockSlashed DelegationState = "TIMELOCK_SLASHED" | ||
StateEarlyUnbondingSlashed DelegationState = "EARLY_UNBONDING_SLASHED" | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fyi @totraev the states that API will return |
||
|
||
// MapDelegationState consumes internal indexer states and maps them to the frontend-facing states | ||
func MapDelegationState(state indexertypes.DelegationState, subState indexertypes.DelegationSubState) (DelegationState, error) { | ||
switch state { | ||
case indexertypes.StatePending: | ||
return StatePending, nil | ||
case indexertypes.StateVerified: | ||
return StateVerified, nil | ||
case indexertypes.StateActive: | ||
return StateActive, nil | ||
|
||
case indexertypes.StateUnbonding: | ||
switch subState { | ||
case indexertypes.SubStateTimelock: | ||
return StateTimelockUnbonding, nil | ||
case indexertypes.SubStateEarlyUnbonding: | ||
return StateEarlyUnbonding, nil | ||
} | ||
|
||
case indexertypes.StateWithdrawable: | ||
switch subState { | ||
case indexertypes.SubStateTimelock: | ||
return StateTimelockWithdrawable, nil | ||
case indexertypes.SubStateEarlyUnbonding: | ||
return StateEarlyUnbondingWithdrawable, nil | ||
case indexertypes.SubStateTimelockSlashing: | ||
return StateTimelockSlashingWithdrawable, nil | ||
case indexertypes.SubStateEarlyUnbondingSlashing: | ||
return StateEarlyUnbondingSlashingWithdrawable, nil | ||
} | ||
|
||
case indexertypes.StateWithdrawn: | ||
switch subState { | ||
case indexertypes.SubStateTimelock: | ||
return StateTimelockWithdrawn, nil | ||
case indexertypes.SubStateEarlyUnbonding: | ||
return StateEarlyUnbondingWithdrawn, nil | ||
case indexertypes.SubStateTimelockSlashing: | ||
return StateTimelockSlashingWithdrawn, nil | ||
case indexertypes.SubStateEarlyUnbondingSlashing: | ||
return StateEarlyUnbondingSlashingWithdrawn, nil | ||
} | ||
|
||
case indexertypes.StateSlashed: | ||
switch subState { | ||
case indexertypes.SubStateTimelock: | ||
return StateTimelockSlashed, nil | ||
case indexertypes.SubStateEarlyUnbonding: | ||
return StateEarlyUnbondingSlashed, nil | ||
} | ||
} | ||
|
||
return "", fmt.Errorf("invalid state/subState combination: state=%s, subState=%s", state, subState) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gusin13 I thought you were planning to store a list of the states this delegation has gone through? Or are you planning to address that in a separate PR later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that will be separate task
babylonlabs-io/babylon-staking-indexer#70
btw although after above ticket is done full list will be available in indexer db, but api won't access or return to fe? or do you think we should return this info to fe?