feat: granular delegation states #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusin13
requested review from
jrwbabylonlab,
jeremy-babylonlabs and
gitferry
| StakingOutputIdx uint32 `bson:"staking_output_idx"` | ||
| UnbondingTime uint32 `bson:"unbonding_time"` | ||
| UnbondingTx string `bson:"unbonding_tx"` | ||
| State indexertypes.DelegationState `bson:"state"` |
There was a problem hiding this comment.
@gusin13 I thought you were planning to store a list of the states this delegation has gone through? Or are you planning to address that in a separate PR later?
There was a problem hiding this comment.
yep that will be separate task
babylonlabs-io/babylon-staking-indexer#70
btw although after above ticket is done full list will be available in indexer db, but api won't access or return to fe? or do you think we should return this info to fe?
| // Slashed states | ||
| StateTimelockSlashed DelegationState = "TIMELOCK_SLASHED" | ||
| StateEarlyUnbondingSlashed DelegationState = "EARLY_UNBONDING_SLASHED" | ||
| ) |
There was a problem hiding this comment.
fyi @totraev the states that API will return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes in v2 delegations endpoint