chore: query fp before register

CHANGELOG.md

@@ -46,6 +46,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 * [#216](https://github.com/babylonlabs-io/finality-provider/pull/216) Add multiple fpd connecting to one eotsd in e2e tests
 * [#218](https://github.com/babylonlabs-io/finality-provider/pull/218) Prune used merkle proof
 * [#221](https://github.com/babylonlabs-io/finality-provider/pull/221) Cleanup TODOs
+* [#226](https://github.com/babylonlabs-io/finality-provider/pull/226) Update local fp before register
 
 ## v0.13.1
 

clientcontroller/interface.go

@@ -51,6 +51,9 @@ type ClientController interface {
 		The following methods are queries to the consumer chain
 	*/
 
+	// QueryFinalityProvider queries the finality provider by pk
+	QueryFinalityProvider(fpPk *btcec.PublicKey) (*btcstakingtypes.QueryFinalityProviderResponse, error)
+
 	// QueryFinalityProviderVotingPower queries the voting power of the finality provider at a given height
 	QueryFinalityProviderVotingPower(fpPk *btcec.PublicKey, blockHeight uint64) (uint64, error)
 

finality-provider/service/app.go

@@ -349,9 +349,30 @@ func (app *FinalityProviderApp) CreateFinalityProvider(
 		return nil, fmt.Errorf("failed to create proof-of-possession of the finality-provider: %w", err)
 	}
 
-	// TODO: query consumer chain to check if the fp is already registered
+	// Query the consumer chain to check if the fp is already registered
 	// if true, update db with the fp info from the consumer chain
 	// otherwise, proceed registration
+	resp, err := app.cc.QueryFinalityProvider(eotsPk.MustToBTCPK())
+	if err != nil {
+		if !strings.Contains(err.Error(), "the finality provider is not found") {
+			return nil, fmt.Errorf("err getting finality provider: %w", err)
+		}
+	}
+	if resp != nil {
+		if err := app.updateFpFromResponse(eotsPk.MustToBTCPK(), resp.FinalityProvider); err != nil {
+			return nil, err
+		}
+
+		// get updated fp from db
+		storedFp, err := app.fps.GetFinalityProvider(eotsPk.MustToBTCPK())
+		if err != nil {
+			return nil, err
+		}
+
+		return &CreateFinalityProviderResult{
+			FpInfo: storedFp.ToFinalityProviderInfo(),
+		}, nil
+	}
 
 	// 3. register the finality provider on the consumer chain
 	request := &CreateFinalityProviderRequest{
@@ -558,3 +579,37 @@ func (app *FinalityProviderApp) getFpPrivKey(fpPk []byte) (*btcec.PrivateKey, er
 
 	return record.PrivKey, nil
 }
+
+func (app *FinalityProviderApp) updateFpFromResponse(btcPk *btcec.PublicKey, fp *bstypes.FinalityProviderResponse) error {
+	if err := app.fps.SetFpDescription(btcPk, fp.Description, fp.Commission); err != nil {
+		return err
+	}
+
+	if err := app.fps.SetFpLastVotedHeight(btcPk, uint64(fp.HighestVotedHeight)); err != nil {
+		return err
+	}
+
+	power, err := app.cc.QueryFinalityProviderVotingPower(btcPk, fp.Height)
+	if err != nil {
+		return fmt.Errorf("failed to query voting power for finality provider %v: %w",
+			btcPk, err)
+	}
+
+	var status proto.FinalityProviderStatus
+	switch {
+	case power > 0:
+		status = proto.FinalityProviderStatus_ACTIVE
+	case fp.SlashedBtcHeight > 0:
+		status = proto.FinalityProviderStatus_SLASHED
+	case fp.Jailed:
+		status = proto.FinalityProviderStatus_JAILED
+	default:
+		status = proto.FinalityProviderStatus_INACTIVE
+	}
+
+	if err := app.fps.SetFpStatus(btcPk, status); err != nil {
+		return fmt.Errorf("failed to update status for finality provider %v: %w", btcPk, err)
+	}
+
+	return nil
+}

finality-provider/service/app_test.go

@@ -64,6 +64,7 @@ func FuzzCreateFinalityProvider(f *testing.F) {
 		mockClientController.EXPECT().QueryLatestFinalizedBlocks(gomock.Any()).Return(nil, nil).AnyTimes()
 		mockClientController.EXPECT().QueryFinalityProviderVotingPower(gomock.Any(),
 			gomock.Any()).Return(uint64(0), nil).AnyTimes()
+		mockClientController.EXPECT().QueryFinalityProvider(gomock.Any()).Return(nil, nil).AnyTimes()
 
 		// Create randomized config
 		fpHomeDir := filepath.Join(t.TempDir(), "fp-home")