chore: query fp before register #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Dec 17, 2024
| return nil, fmt.Errorf("err getting finality provider: %w", err) | ||
| } | ||
| } | ||
| if resp != nil { |
There was a problem hiding this comment.
let's have a log here to indicate the registration is already done
finality-provider/service/app.go
Outdated
Comment on lines
594
to
595
| return fmt.Errorf("failed to query voting power for finality provider %v: %w", | ||
| btcPk, err) |
There was a problem hiding this comment.
let's print the hex string of the public key
There was a problem hiding this comment.
Can we have a test case where the fp is already registered but not in db, so calling CreateFinalityProvider will save the fp in db?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes