Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip slashing event for delegations w/o inclusion proof #98

Merged
merged 3 commits into from
Dec 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/services/delegation.go
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,14 @@ func (s *Service) processSlashedFinalityProviderEvent(
}

for _, delegation := range delegations {
if !delegation.HasInclusionProof() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are we consuming the events?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api is consuming events.

api atm just have 2 handlers active/unbonding

both unbonding(early/natural) and slashing events are pushed to same queue (unbonding queue)

log.Debug().
Str("staking_tx", delegation.StakingTxHashHex).
Str("reason", "missing_inclusion_proof").
Msg("skipping slashed delegation event")
continue
}

if err := s.emitUnbondingDelegationEvent(ctx, delegation); err != nil {
return err
}
Expand Down
Loading