fix: skip slashing event for delegations w/o inclusion proof #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwbabylonlab
approved these changes
Dec 23, 2024
jrwbabylonlab
approved these changes
Dec 23, 2024
| @@ -472,6 +472,14 @@ func (s *Service) processSlashedFinalityProviderEvent( | |||
| } | |||
|
|
|||
| for _, delegation := range delegations { | |||
| if !delegation.HasInclusionProof() { | |||
There was a problem hiding this comment.
where are we consuming the events?
There was a problem hiding this comment.
api is consuming events.
api atm just have 2 handlers active/unbonding
both unbonding(early/natural) and slashing events are pushed to same queue (unbonding queue)
|
Fix make sense. i will merge and deploy for now. We can continue the discussion in the comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - babylonlabs-io/staking-api-service#176
Its possible for delegations to be slashed (even if they don't have inclusion proof i.e they are not submitted to btc)
This edge case has led to wrong calculation in stats, b/c the slashed event will lead to subtraction but the delegation was never active so the tvl etc will be negative