Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Async on RP2040 #170

Merged

Conversation

DoomHammer
Copy link

No description provided.

@DoomHammer DoomHammer force-pushed the enable-async-on-rp2040 branch from 3d256c1 to de42ccc Compare March 27, 2024 12:52
@ayushsharma82
Copy link
Owner

Thanks for the PR @DoomHammer ! I'll soon review and merge it for next release.

@mathieucarbou
Copy link
Contributor

@DoomHammer : FYI I am maintaining a fork of ESPAsyncWebServer (https://github.com/mathieucarbou/ESPAsyncWebServer) which is used in many projects / lot of deployments.

I saw this PR, but until there is a valid AsyncTCP lib for RPI, it won't be possible to add support for RPI inside.

The Async lib (https://github.com/khoih-prog/AsyncTCP_RP2040W) used as dependency is archived and not maintained. The code greatly differ from the original ESPAsyncTCP (this is not even a fork), and has been completely renamed / restructured / refactored and reformatted. So it's not even possible to get a diff out of it and reapply it to a fork of ESPAsyncTCP.

ESPAsyncTCP and ESP8266 in general are / will be in the same boat...

@DoomHammer
Copy link
Author

What do you mean, @mathieucarbou ? I've used this fork: https://github.com/skilau/ESPAsyncWebServer with some additional changes and I was generally satisfied with it.

@mathieucarbou
Copy link
Contributor

What do you mean, @mathieucarbou ? I've used this fork: https://github.com/skilau/ESPAsyncWebServer with some additional changes and I was generally satisfied with it.

ESPAsyncWebServer has some dependencies, which have also been ported. Look at the source code and project descriptors ;-)

The problem is that both the fork you use plus its dependencies are 1) not maintained and/or 2) archived, which means the developer specifically doesn't want anybody to use the dependencies anymore, whatever his reasons.

To have this project work on rpi you need all dependencies to work and be ported to rpi and also be maintained, released, etc.

Other option is to takeover his work and support it.

But who will do that ?
Only someone heavily working on rpi could...

@ayushsharma82 ayushsharma82 changed the base branch from master to dev June 13, 2024 18:24
@ayushsharma82
Copy link
Owner

No worries. I'll list different dependencies in docs.

@ayushsharma82 ayushsharma82 changed the base branch from dev to picow-async June 13, 2024 18:49
@ayushsharma82 ayushsharma82 merged commit 396c939 into ayushsharma82:picow-async Jun 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants