-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arduino 3 / ESP-IDF 5 compatibility #178
Conversation
bb42b53
to
846f73f
Compare
a50361f
to
4093f86
Compare
@ayushsharma82 : applied same recipe as ESP-DASH here. CI is passing in my fork (main and this PR branch): https://github.com/mathieucarbou/ayushsharma82-ElegantOTA/actions |
Also, platform |
Yea, there is RP2040 support in ElegantOTA so CI should test that too. Check the other PR #170, does your fork of ESPAsyncWebServer have RP2040 support? (Ref: DoomHammer/ESPAsyncWebServer@06062ec ) |
Oh boy! There's a problem here... #170 (saw it already) depends on an external fork of ESPAsyncWebserver, and, even if I could import the diff in my fork, the real issue is that it depends on a different AsyncTCP lib which is now archived (https://github.com/khoih-prog/AsyncTCP_RP2040W) and not even based (forked) from the original ones... It seems like a dead end to me... |
Yeah... We can still add CI for testing |
Let me know if you can do it otherwise I'll tackle it next weekend. :) |
yes this one can be activated if not depending on Async stuff. What's problematic is I think making this project depend on some unsupported / archived dependencies like the forks (which are not even forks lol) of ESPAyncTCP and ESPAsyncWebServer for RPI.
You can edit my PR and commit. |
Added raspberry pico to CI in my Btw, I noticed you are not using conventional commits, although it is not "required", this is something which I started using recently. I find it really great because using this 'convention' scripts can auto increment version by looking through commit history. |
This PR updates the CI system and dependencies in order to make the library compatible with Arduino 3 / ESP-IDF 5, and of course Arduino 2.
The project itself does not require any change, except the library.json for PlatformIO projects, but alternate dependencies must be used, which have been updated:
Example:
Note: the change to
https://github.com/mathieucarbou/esphome-ESPAsyncTCP#v2.0.0
is because ESPHome have deleted the library.properties file from the original fork.You can see an sample of what will the CI look like here in my fork: https://github.com/mathieucarbou/ayushsharma82-ElegantOTA/actions/runs/8773016893