Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate sample packing requires flash_attention #1465

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: check for sdp_attn per suggestion
NanoCode012 authored and winglian committed Apr 5, 2024
commit 572c9e49543260c9dd5a0f5121c10a99c5e1efae
8 changes: 6 additions & 2 deletions src/axolotl/utils/config/models/input/v0_4_1/__init__.py
Original file line number Diff line number Diff line change
@@ -659,9 +659,13 @@ def check_sample_packing_w_xformers(cls, data):
@model_validator(mode="before")
@classmethod
def check_sample_packing_wo_flash(cls, data):
if data.get("sample_packing") and not data.get("flash_attention"):
if (
data.get("sample_packing")
and not data.get("flash_attention")
and not data.get("sdp_attention")
):
raise ValueError(
"sample_packing requires flash_attention to be set to true"
"sample_packing requires flash_attention or sdp_attention to be set to true"
)

return data