feat: validate sample packing requires flash_attention #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I found that we support sample_packing with sdpa, so this PR and relevant Issue should be closed? |
winglian
reviewed
Mar 30, 2024
winglian
approved these changes
Apr 5, 2024
winglian
force-pushed
the
feat/validate_samplepacking_flash
branch
from
f9907bc to
df936a9
Compare
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* feat: validate sample packing requires flash_attention * fix: check for sdp_attn per suggestion * feat: add FA to tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #449
We can also remove a few if checks because of this.
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)