Replace test_data_quality_at_scale.ipynb #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the dataset (amazon products reviews replaced with a synthetic data), added a couple of new examples
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Replaced Amazon Reviews with a synthetically generated reviews dataset; added declaration of the SPARK version
updated tutorials to use a new dataset
chenliu0831
reviewed
Aug 15, 2024
| @@ -6,14 +6,115 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
I don't see a reason the same code won't work with pydeequ 1.4.0/Spark 3.5. I think it might be fine to insert something like "Tested on pydeequ 1.2.0/Spark 3.3. Code should run on all supported pydeequ versions".
Reply via ReviewNB
| @@ -6,14 +6,115 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
Line #2. os.environ["SPARK_VERSION"] = '3.3'
Maybe add ad comment that mention setting this to 3.5 if one use pydeequ 1.4.0
Reply via ReviewNB
|
Minor comment - I can approve when addressed. |
|
Created a new pull request #230 to address the comments above. |
komashk
added a commit
to komashk/python-deequ
that referenced
this pull request
Aug 21, 2024
…addressed PR comments awslabs#208 and awslabs#230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the dataset (amazon products reviews replaced with a synthetic data), added a couple of new examples
issue #207 issue #209
Description of changes:
Two updates:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.