-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSProcessing] Improve Spark config to better support EMR/EMRS, small optimizations #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvasilo
added
draft
label only to be used by dev team - skips CI for small changes
0.3
gsprocessing
For issues and PRs related the the GSProcessing library
labels
May 14, 2024
thvasilo
changed the title
[GSProcessing] Improve Spark config to better support EMR/EMRS, small optimizations
[Draft][GSProcessing] Improve Spark config to better support EMR/EMRS, small optimizations
May 15, 2024
thvasilo
force-pushed
the
gsp-spark-config
branch
from
May 17, 2024 23:24
05d58d0
to
4175c26
Compare
…tadata.json when only Parquet metadata is changed
thvasilo
force-pushed
the
gsp-spark-config
branch
from
May 17, 2024 23:25
4175c26
to
7a4e2f6
Compare
thvasilo
changed the title
[Draft][GSProcessing] Improve Spark config to better support EMR/EMRS, small optimizations
[GSProcessing] Improve Spark config to better support EMR/EMRS, small optimizations
May 17, 2024
thvasilo
removed
the
draft
label only to be used by dev team - skips CI for small changes
label
May 17, 2024
jalencato
reviewed
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
...ng/graphstorm_processing/data_transformations/dist_transformations/dist_hf_transformation.py
Show resolved
Hide resolved
graphstorm-processing/graphstorm_processing/graph_loaders/dist_heterogeneous_loader.py
Show resolved
Hide resolved
thvasilo
commented
May 23, 2024
graphstorm-processing/graphstorm_processing/data_transformations/spark_utils.py
Outdated
Show resolved
Hide resolved
Should have resolved all comments @jalencato, let me know if there's any more work left to merge. |
jalencato
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.3
gsprocessing
For issues and PRs related the the GSProcessing library
ready
able to trigger the CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
:
in the data paths, as it can cause errors when moving the data to local filesystems.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.