Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding namespaces read permissions to eksa-controller #8017

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Adding namespaces read permissions to eksa-controller #8017

merged 1 commit into from
Apr 19, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Apr 19, 2024

Issue #https://github.com/aws/eks-anywhere-internal/issues/2268

Description of changes:
eksa controller did not have permissions to read namespaces. The packages helm chart does a lookup to check if namespace needs to be created. This was failing and hence packages were not installed on workload cluster.

 error calling lookup: namespaces \"eksa-packages-workload\" is forbidden: User \"system:serviceaccount:eksa-system:eksa-controller-manager\" cannot get resource \"namespaces\" in API group \"\" in the namespace \"eksa-packages-workload\"\

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2024
@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 18edabc into aws:main Apr 19, 2024
10 checks passed
pokearu added a commit to pokearu/eks-anywhere that referenced this pull request Apr 22, 2024
@pokearu
Adding namespaces read permissions to eksa controller (aws#8017)
d53cff2
@pokearu pokearu mentioned this pull request Apr 22, 2024
Merged
pokearu added a commit that referenced this pull request Apr 22, 2024
@pokearu
🍒 Cherry pick packages with registry mirror fixes (#8029)
355de0a 
* Adding a helm login to packages reconcile flow for workload clusters (#7971)

* Adding permissions for controller packages helm upgrade (#8012)

* Adding namespaces read permissions to eksa controller (#8017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavmpandey08 abhinavmpandey08 Awaiting requested review from abhinavmpandey08

@abhay-krishna abhay-krishna Awaiting requested review from abhay-krishna

Assignees

@abhay-krishna abhay-krishna

Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pokearu @abhay-krishna @eks-distro-bot