Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a helm login to packages reconcile flow for workload clusters #7971

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Apr 11, 2024

Issue https://github.com/aws/eks-anywhere-internal/issues/2269:

Description of changes:
This solves part one of the issue when creating a workload clusters with an authenticated registry mirror. The EKS-A controller is responsible for performing a helm install of the eks-anywhere-packages helm chart for a workload cluster; this was failing because

  1. We did pass the --insecure-skip-tls-verify flag during the helm install.
  2. For authenticated registry mirrors; we did not perform a helm login before running the helm install.

The changes in this PR fixes both the issues, hence customers who use kubectl to create a workload cluster would now get have packages enabled successfully when having an auth registry mirror.

Testing:

eksctl-anywhere create cluster -f cluster.yaml --kubeconfig mgmt.kubeconfig --bundles-override bundle.yaml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2024
@pokearu pokearu requested a review from tatlat April 11, 2024 23:27
@pokearu pokearu force-pushed the packages-reconcile-regauth branch from 49184a4 to b25874c Compare April 11, 2024 23:32
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (3fe6cc7) to head (b25874c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7971   +/-   ##
=======================================
  Coverage   73.42%   73.43%           
=======================================
  Files         577      577           
  Lines       35821    35827    +6     
=======================================
+ Hits        26302    26308    +6     
  Misses       7854     7854           
  Partials     1665     1665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member

tatlat commented Apr 11, 2024

/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@tatlat: dog image

In response to this:

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 0c4cb91 into aws:main Apr 11, 2024
13 checks passed
@pokearu
Copy link
Member Author

pokearu commented Apr 22, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@pokearu: new pull request created: #8028

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pokearu added a commit to pokearu/eks-anywhere that referenced this pull request Apr 22, 2024
pokearu added a commit that referenced this pull request Apr 22, 2024
* Adding a helm login to packages reconcile flow for workload clusters (#7971)

* Adding permissions for controller packages helm upgrade (#8012)

* Adding namespaces read permissions to eksa controller (#8017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants