-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a helm login to packages reconcile flow for workload clusters #7971
Conversation
49184a4
to
b25874c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7971 +/- ##
=======================================
Coverage 73.42% 73.43%
=======================================
Files 577 577
Lines 35821 35827 +6
=======================================
+ Hits 26302 26308 +6
Misses 7854 7854
Partials 1665 1665 ☔ View full report in Codecov by Sentry. |
/lgtm |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.19 |
@pokearu: new pull request created: #8028 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue https://github.com/aws/eks-anywhere-internal/issues/2269:
Description of changes:
This solves part one of the issue when creating a workload clusters with an authenticated registry mirror. The EKS-A controller is responsible for performing a helm install of the
eks-anywhere-packages
helm chart for a workload cluster; this was failing because--insecure-skip-tls-verify
flag during the helm install.The changes in this PR fixes both the issues, hence customers who use
kubectl
to create a workload cluster would now get have packages enabled successfully when having an auth registry mirror.Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.