Clean up funcs around power on and off: #7512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed skipped tinkerbell tests that used power on or off. Removed power on and off from all other tests. We should not be powering on or off machines manually. ValidateHardwareDecommissioned will now validate machines are off and then if any are not off we call powerOffHardware and fail the test. We power off so that subsequent runs won't have issues with multiple Boots DHCP servers running. Also updated the logic around checking the response from bmclib for power state. Depending on the provider the power state comes back different. For example, with ipmitool the result will be "Chassis Power is off", while with redfish the result will be "off". Signed-off-by: Jacob Weinstock <[email protected]>
eks-distro-bot
added
the
size/L
Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7512 +/- ##
=======================================
Coverage 73.48% 73.49%
=======================================
Files 579 579
Lines 36357 36362 +5
=======================================
+ Hits 26718 26723 +5
Misses 7875 7875
Partials 1764 1764 ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobweinstock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Removed skipped tinkerbell tests that used power on or off. Removed power on and off from all other tests. We should not be powering on or off machines manually. ValidateHardwareDecommissioned will now validate machines are off and then if any are not off we call powerOffHardware and fail the test. We power off so that subsequent runs won't have issues with multiple Boots DHCP servers running.
Also updated the logic around checking the response from bmclib for power state. Depending on the provider the power state comes back different. For example, with ipmitool the result will be "Chassis Power is off", while with redfish the result will be "off".
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.