Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old comment related to the tinkerbell e2e skip power action #8592

Closed

Conversation

panktishah26
Copy link
Member

Description of changes:
We do not need this comment to skip power action related Tinkerbell e2e tests as we have decided to remove power action related tests with this PR
#7512

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from panktishah26. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.53%. Comparing base (a5ee855) to head (effb147).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8592   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files         578      578           
  Lines       36558    36558           
=======================================
  Hits        26883    26883           
  Misses       7955     7955           
  Partials     1720     1720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26
Copy link
Member Author

The change will be covered in another PR.

@panktishah26 panktishah26 deleted the remove-e2e-comment-poweraction branch December 20, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants